Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_extensions_scarlet
-
Labels:None
-
Story Points:5
-
Epic Link:
-
Sprint:DRP F20-5 (Oct), DRP S21a (Dec Jan)
-
Team:Data Release Production
-
Urgent?:No
Description
This ticket has been modified to skip sky objects during deblending, the reason being that having deblended sky objects is not useful as a diagnostic tool and scarlet doesn't like trying to model something that isn't there.
While implementing this I realized that a number of columns weren't being updated properly, and that ScarletDeblendTask could use a bit of a spring cleaning. So the first commit is a refactoring of ScarletDeblend task. The second is an update to the tests to make sure that things are properly persisted in the future, and the third is the update to skip sky objects.
Attachments
Issue Links
Activity
This ticket has been completed and included a refactoring that was not part of the original ticket description. The issue is that the columns were not being updated properly because meas_extensions_scarlet copied the input mergeDet catalog into a catalog for each band, but frequently the parents in the input catalog were modified as opposed to the output catalog. This seemed like a failure mode that would continue to crop up in the future so I included a refactor of meas_extensions_scarlet that now deblends the entire mergeDet catalog, setting all of the flags for the parent and child sources in a single catalog. Once deblending has been completed the single band version of the catalog are duplicated from the original and the band dependent columns and footprints are then modified and returned.
Fred Moolekamp
added a comment - This ticket has been completed and included a refactoring that was not part of the original ticket description. The issue is that the columns were not being updated properly because meas_extensions_scarlet copied the input mergeDet catalog into a catalog for each band, but frequently the parents in the input catalog were modified as opposed to the output catalog. This seemed like a failure mode that would continue to crop up in the future so I included a refactor of meas_extensions_scarlet that now deblends the entire mergeDet catalog, setting all of the flags for the parent and child sources in a single catalog. Once deblending has been completed the single band version of the catalog are duplicated from the original and the band dependent columns and footprints are then modified and returned. Hi Dan,
Would you mind reviewing this ticket for me?
Thanks,
-Fred
Fred Moolekamp
added a comment - Hi Dan,
Would you mind reviewing this ticket for me?
Thanks,
-Fred Successful Jenkins build (including ci_hsc): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33849/pipeline
Fred Moolekamp
added a comment - Successful Jenkins build (including ci_hsc): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33849/pipeline I only have minor pedantry for mes. You may want to re-Jenkins after rebasing pipe_tasks.
Thanks Dan. Rerun of Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33896/pipeline
Fred Moolekamp
added a comment - Thanks Dan. Rerun of Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33896/pipeline 
The changes in this ticket make use of features implemented in
DM-28542(and also update the tests in that ticket). So while the work for this issue is completed, it cannot be implemented untilDM-28542is merged.