Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28004

ExposureInfo may persist dummy FilterLabels

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:

      Description

      Before the introduction of FilterLabel in DM-27169, every ExposureInfo had a Filter, which may have been the "default" filter ("_unknown_", -1). Some downstream code in obs_base took advantage of this behavior to pass invalid filters unconditionally to Exposure.setFilter.

      The implementation of FilterLabel in ExposureInfo allows an exposure to not have any filter information, and this representation should be preferred over FilterLabel(physical="_unknown_"). While there is a check to prevent this in the ExposureInfo constructor, setFilter assumes that any Filter passed to it must be valid. Rewrite the checks so that it is impossible to convert the default Filter into a FilterLabel.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            One question about whether this and how this might be testable, but I think you're good to merge.

            Show
            Parejkoj John Parejko added a comment - One question about whether this and how this might be testable, but I think you're good to merge.

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              John Parejko
              Watchers:
              John Parejko, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.