Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28144

Make a Gen 3 version of the stellar locus plots in pipe_analysis

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • None
    • 20
    • Data Release Production
    • No

    Description

      As part of the conversion of pipe_analysis to gen 3 the stellar locus plots need to be remade. A few of the steps that need to be done to achieve this are:

      Figuring out exactly which points are used in the gen 2 version and why.

      Getting the plotting code to work and convey the relevant information.

      Getting the fitting to work well and quickly.

      Separating out the calculation steps into another task and store the outputs in a useful way.

      Attachments

        1. wFitCModel.png
          wFitCModel.png
          117 kB
        2. wFitPsf.png
          wFitPsf.png
          111 kB
        3. xFitCModel.png
          xFitCModel.png
          125 kB
        4. xFitPsf.png
          xFitPsf.png
          119 kB
        5. yFitCModel.png
          yFitCModel.png
          101 kB
        6. yFitPsf.png
          yFitPsf.png
          106 kB

        Issue Links

          Activity

            See comments on the PR. I'm sure there are many things to discuss about how to "optimize" these plots to give us useful information, but I've kept my comments to the code/method for now. It seems like you've made it flexible enough to enable selection criteria and fitting params via configs.

            P. S. – the figures look nice!

            jcarlin Jeffrey Carlin added a comment - See comments on the PR. I'm sure there are many things to discuss about how to "optimize" these plots to give us useful information, but I've kept my comments to the code/method for now. It seems like you've made it flexible enough to enable selection criteria and fitting params via configs. P. S. – the figures look nice!

            Oh, one other thing – I can imagine it being useful to return the values of "P1" (the position along the locus) in addition to the "P2" values (as you've implemented with "distToLine"). (A simple function to calculate/return those values given the fit coefficients would work?)

            jcarlin Jeffrey Carlin added a comment - Oh, one other thing – I can imagine it being useful to return the values of "P1" (the position along the locus) in addition to the "P2" values (as you've implemented with "distToLine"). (A simple function to calculate/return those values given the fit coefficients would work?)
            sophiereed Sophie Reed added a comment -

            I thought I would make a new ticket for P1, I want to clarify what statistics we actually want to plot and calculate. Also how to calculate them.

            sophiereed Sophie Reed added a comment - I thought I would make a new ticket for P1, I want to clarify what statistics we actually want to plot and calculate. Also how to calculate them.

            Story points please.

            yusra Yusra AlSayyad added a comment - Story points please.

            People

              sophiereed Sophie Reed
              sophiereed Sophie Reed
              Jeffrey Carlin
              Jeffrey Carlin, Lauren MacArthur, Sophie Reed, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.