Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28144

Make a Gen 3 version of the stellar locus plots in pipe_analysis

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      20
    • Epic Link:
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      As part of the conversion of pipe_analysis to gen 3 the stellar locus plots need to be remade. A few of the steps that need to be done to achieve this are:

      Figuring out exactly which points are used in the gen 2 version and why.

      Getting the plotting code to work and convey the relevant information.

      Getting the fitting to work well and quickly.

      Separating out the calculation steps into another task and store the outputs in a useful way.

        Attachments

        1. wFitCModel.png
          wFitCModel.png
          117 kB
        2. wFitPsf.png
          wFitPsf.png
          111 kB
        3. xFitCModel.png
          xFitCModel.png
          125 kB
        4. xFitPsf.png
          xFitPsf.png
          119 kB
        5. yFitCModel.png
          yFitCModel.png
          101 kB
        6. yFitPsf.png
          yFitPsf.png
          106 kB

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14196 Explore the Principle Color fit sensitivity to magnitude limits

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14590 Refine HSC Principle Color coefficient calibration based on latest PDR1 processing

          • To Do
          is child task of

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28146 Make a gen 3 version of color_analysis

          • To Do
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jcarlin Jeffrey Carlin added a comment -

            See comments on the PR. I'm sure there are many things to discuss about how to "optimize" these plots to give us useful information, but I've kept my comments to the code/method for now. It seems like you've made it flexible enough to enable selection criteria and fitting params via configs.

            P. S. – the figures look nice!

            Show
            jcarlin Jeffrey Carlin added a comment - See comments on the PR. I'm sure there are many things to discuss about how to "optimize" these plots to give us useful information, but I've kept my comments to the code/method for now. It seems like you've made it flexible enough to enable selection criteria and fitting params via configs. P. S. – the figures look nice!
            Hide
            Permalink
            jcarlin Jeffrey Carlin added a comment -

            Oh, one other thing – I can imagine it being useful to return the values of "P1" (the position along the locus) in addition to the "P2" values (as you've implemented with "distToLine"). (A simple function to calculate/return those values given the fit coefficients would work?)

            Show
            jcarlin Jeffrey Carlin added a comment - Oh, one other thing – I can imagine it being useful to return the values of "P1" (the position along the locus) in addition to the "P2" values (as you've implemented with "distToLine"). (A simple function to calculate/return those values given the fit coefficients would work?)
            Hide
            Permalink
            sophiereed Sophie Reed added a comment -

            I thought I would make a new ticket for P1, I want to clarify what statistics we actually want to plot and calculate. Also how to calculate them.

            Show
            sophiereed Sophie Reed added a comment - I thought I would make a new ticket for P1, I want to clarify what statistics we actually want to plot and calculate. Also how to calculate them.
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            Story points please.

            Show
            yusra Yusra AlSayyad added a comment - Story points please.

              People

              Assignee:
              sophiereed Sophie Reed
              Reporter:
              sophiereed Sophie Reed
              Reviewers:
              Jeffrey Carlin
              Watchers:
              Jeffrey Carlin, Lauren MacArthur, Sophie Reed, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.