Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28149

Make gen 3 scatter plots for the gen 3 version of color analysis

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • None
    • 18
    • DRP S21b
    • Data Release Production
    • No

    Description

      There are a number of plots in the gen 2 version of color_analysis that are a scatter plot with histograms of each axis. Make the versions of these that are being kept into gen 3.

      Attachments

        Issue Links

          Activity

            I'm assuming that the repo/collection that hosts the to-be-reviewed versions of the PsfSn_goodCModel_stars_scatter and PsfSn_goodCModel_all_scatter is /repo/main and collection u/sr525/plotTests.  If there are other plots I should look at, let me know.

            tmorton Tim Morton [X] (Inactive) added a comment - I'm assuming that the repo/collection that hosts the to-be-reviewed versions of the PsfSn_goodCModel_stars_scatter and PsfSn_goodCModel_all_scatter is /repo/main and collection u/sr525/plotTests .  If there are other plots I should look at, let me know.

            Reviewed on GH, just one additional soft suggestion that I mention on GH also but repeat here: I think it might be instructive to run an example of this kind of plot for something other than a mag as the x axis. To me, this would help make clear whether a distinction really is necessary between `xCol` and `magCol`, and also whether there are any other built-in gotchas that come from all of the usage to date being with mag as x-col. In other words, this is built as a general x-y scatter plot thing, but as is it might work actually less generally than intended (especially with the drawing of the paths, etc.), in which case maybe we should be content with this being just more narrowly a MagScatterHistPlot or something.

            tmorton Tim Morton [X] (Inactive) added a comment - Reviewed on GH, just one additional soft suggestion that I mention on GH also but repeat here: I think it might be instructive to run an example of this kind of plot for something other than a mag as the x axis. To me, this would help make clear whether a distinction really is necessary between `xCol` and `magCol`, and also whether there are any other built-in gotchas that come from all of the usage to date being with mag as x-col. In other words, this is built as a general x-y scatter plot thing, but as is it might work actually less generally than intended (especially with the drawing of the paths, etc.), in which case maybe we should be content with this being just more narrowly a MagScatterHistPlot or something.

            All looks good!

            tmorton Tim Morton [X] (Inactive) added a comment - All looks good!

            People

              sophiereed Sophie Reed
              sophiereed Sophie Reed
              Tim Morton [X] (Inactive)
              Sophie Reed, Tim Morton [X] (Inactive), Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.