Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28158

2021-12-31 is not far enough in the future to trigger an Astropy warning

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None

      Description

      test_translator.LsstMetadataTranslatorTestCase testMethod=test_imsim_translator failed in the lsst_distrib clean build, probably since we're now less than 53 weeks from the purported observation date, so it's not far enough in the future to trigger the expected warning.

        Attachments

          Activity

          No builds found.
          ktl Kian-Tat Lim created issue -
          Hide
          ktl Kian-Tat Lim added a comment -

          I'm not sure why this only shows up in the clean build and not in the release or tarball executions.

          Show
          ktl Kian-Tat Lim added a comment - I'm not sure why this only shows up in the clean build and not in the release or tarball executions.
          frossie Frossie Economou made changes -
          Field Original Value New Value
          Team Architecture [ 10304 ]
          Hide
          jbosch Jim Bosch added a comment -

          Stealing this because just pushing the date into the future seems easy and it's getting in the way of Jenkins-testing of other tickets. Anyone else is welcome to look into the mysteries of why this only sometimes happens on another ticket later (assuming this is as easy for me as it seems).

          Show
          jbosch Jim Bosch added a comment - Stealing this because just pushing the date into the future seems easy and it's getting in the way of Jenkins-testing of other tickets. Anyone else is welcome to look into the mysteries of why this only sometimes happens on another ticket later (assuming this is as easy for me as it seems).
          jbosch Jim Bosch made changes -
          Epic Link DM-27974 [ 442759 ]
          Team Architecture [ 10304 ] Data Release Production [ 10301 ]
          Assignee Jim Bosch [ jbosch ]
          jbosch Jim Bosch made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          Hide
          jbosch Jim Bosch added a comment -

          Also asking for volunteer reviews on Slack; if anyone else gets to it before K-T, just mark Reviewed.

          Show
          jbosch Jim Bosch added a comment - Also asking for volunteer reviews on Slack; if anyone else gets to it before K-T, just mark Reviewed.
          jbosch Jim Bosch made changes -
          Reviewers Kian-Tat Lim [ ktl ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          jbosch Jim Bosch made changes -
          Reporter Kian-Tat Lim [ ktl ] Ian Sullivan [ sullivan ]
          jbosch Jim Bosch made changes -
          Reporter Ian Sullivan [ sullivan ] Kian-Tat Lim [ ktl ]
          jbosch Jim Bosch made changes -
          Reviewers Kian-Tat Lim [ ktl ] Ian Sullivan [ sullivan ]
          Hide
          sullivan Ian Sullivan added a comment -

          This looks fine, and I'm happy that this will solve the immediate problem. I'm a little worried this might trip us up again in the future, when the ImSim data might instead be too far in the past. Could you instead catch this specific type of error with a try/except block, or would that defeat the test?

          Show
          sullivan Ian Sullivan added a comment - This looks fine, and I'm happy that this will solve the immediate problem. I'm a little worried this might trip us up again in the future, when the ImSim data might instead be too far in the past. Could you instead catch this specific type of error with a try/except block, or would that defeat the test?
          sullivan Ian Sullivan made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          jbosch Jim Bosch made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          yusra Yusra AlSayyad made changes -
          Story Points 1
          Hide
          mjuric Mario Juric added a comment - - edited

          I think I just hit this trying to build {{eups distrib install -t v21_0_0 lsst_distrib }}for the SolSysSciCol sprint.

          Is there a workaround (I'd like to stick to the official release, as this will be used for the next ~year)?

          Show
          mjuric Mario Juric added a comment - - edited I think I just hit this trying to build {{eups distrib install -t v21_0_0 lsst_distrib }}for the SolSysSciCol sprint. Is there a workaround (I'd like to stick to the official release, as this will be used for the next ~year)?
          Hide
          ktl Kian-Tat Lim added a comment -

          You could try installing from binaries instead; I think that should bypass the tests.

          Alternatives include waiting for the much-improved and almost-out-the-door v22 or requesting a v21_0_1 patch (which, due to various reasons, almost certainly cannot come out before v22 does).

          Show
          ktl Kian-Tat Lim added a comment - You could try installing from binaries instead; I think that should bypass the tests. Alternatives include waiting for the much-improved and almost-out-the-door v22 or requesting a v21_0_1 patch (which, due to various reasons, almost certainly cannot come out before v22 does).
          ktl Kian-Tat Lim made changes -
          Comment [ You could try installing from binaries instead; I think that should bypass the tests.

          Alternatives include waiting for the much-improved and almost-out-the-door v22 or requesting a v21_0_1 patch (which, due to various reasons, almost certainly cannot come out before v22 does). ]
          ktl Kian-Tat Lim made changes -
          Comment [ You could try installing from binaries instead; I think that should bypass the tests. ]
          Hide
          mjuric Mario Juric added a comment - - edited

          The machines involved are on Ubuntu, so newinstall demands a rebuild .

          I'm trying again with w_latest (need this for later today, unfortunately).

          Show
          mjuric Mario Juric added a comment - - edited The machines involved are on Ubuntu, so newinstall demands a rebuild . I'm trying again with w_latest (need this for later today, unfortunately).
          Hide
          jbosch Jim Bosch added a comment -

          Binaries work fine on Ubuntu (ever since we switched to conda compilers/stdlibs); I do it all the time. You just need to lie about your OS, by setting

          EUPS_PKGROOT=https://eups.lsst.codes/stack/redhat/el7/conda-system/miniconda3-py38_4.9.2-0.6.0

          Show
          jbosch Jim Bosch added a comment - Binaries work fine on Ubuntu (ever since we switched to conda compilers/stdlibs); I do it all the time. You just need to lie about your OS, by setting EUPS_PKGROOT= https://eups.lsst.codes/stack/redhat/el7/conda-system/miniconda3-py38_4.9.2-0.6.0
          Hide
          mjuric Mario Juric added a comment -

          Thanks Jim Bosch – while it comes too late this time around, I will use it next time I need it.

          This seems like a bug, though – shouldn't the install script know this? If so, can someone (Kian-Tat Lim?) pass this issue on to the right person in the packaging team to be considered for a fix? I've spent about 6 hours waiting for numerous from-source builds to fail yesterday (until the last one succeeded).

          Show
          mjuric Mario Juric added a comment - Thanks Jim Bosch – while it comes too late this time around, I will use it next time I need it. This seems like a bug, though – shouldn't the install script know this? If so, can someone ( Kian-Tat Lim ?) pass this issue on to the right person in the packaging team to be considered for a fix? I've spent about 6 hours waiting for numerous from-source builds to fail yesterday (until the last one succeeded).

            People

            Assignee:
            jbosch Jim Bosch
            Reporter:
            ktl Kian-Tat Lim
            Reviewers:
            Ian Sullivan
            Watchers:
            Ian Sullivan, Jim Bosch, Kian-Tat Lim, Mario Juric, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.