Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28166

Update obs package use of filter.getId() in _computeCoaddExposureId

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Urgent?:
      No

      Description

      This may be a "won't fix" because it only affects the gen2 CameraMappers, but lsst, subaru, decam, and cfht all use filter.getId() in their calculation of the singleFilter coadd exposure id. The new FilterLabel does not have a numeric Id, so these mappers will have to be changed. However, I do not know what the time ordering of gen2 removal vs. Filter removal is: if gen2 is removed first, then this won't matter at all.

      I did not change this on DM-27170 because I did not want to alter this calculation in gen2 without more discussion, and want to get that ticket finished up.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment - - edited

            I'm trying to implement DM-27177 and have just run into this issue in obs.lsst.LsstCamBaseMapper._computeCoaddExposureId. How should I handle it? Should I just have _computeCoaddExposureId raise NotImplementedError? Should I remove the if singleFilter block? Hash the filter name?

            I have no idea what will break if, for example, the IDs are no longer unique.

            Show
            krzys Krzysztof Findeisen added a comment - - edited I'm trying to implement DM-27177 and have just run into this issue in obs.lsst.LsstCamBaseMapper._computeCoaddExposureId . How should I handle it? Should I just have _computeCoaddExposureId raise NotImplementedError ? Should I remove the if singleFilter block? Hash the filter name? I have no idea what will break if, for example, the IDs are no longer unique.
            Hide
            tjenness Tim Jenness added a comment -

            I'm about to merge DM-34919 (as soon as the jira ticket is marked reviewed) and that will delete this code.

            Show
            tjenness Tim Jenness added a comment - I'm about to merge DM-34919 (as soon as the jira ticket is marked reviewed) and that will delete this code.
            Hide
            tjenness Tim Jenness added a comment -

            Krzysztof Findeisen That code should no longer exist.

            Show
            tjenness Tim Jenness added a comment - Krzysztof Findeisen That code should no longer exist.
            Hide
            krzys Krzysztof Findeisen added a comment -

            Confirmed, but I had to deal with something similar in obs_cfht. I took the hash approach; so far it's passing tests.

            Show
            krzys Krzysztof Findeisen added a comment - Confirmed, but I had to deal with something similar in obs_cfht . I took the hash approach; so far it's passing tests.
            Hide
            tjenness Tim Jenness added a comment -

            I also have a ticket in review to remove the code from obs_cfht...

            Show
            tjenness Tim Jenness added a comment - I also have a ticket in review to remove the code from obs_cfht...

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Ian Sullivan, Jim Bosch, John Parejko, Krzysztof Findeisen, Lauren MacArthur, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.