# Update obs package use of filter.getId() in _computeCoaddExposureId

XMLWordPrintable

#### Details

• Type: Story
• Status: Won't Fix
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
2
• Urgent?:
No

#### Description

This may be a "won't fix" because it only affects the gen2 CameraMappers, but lsst, subaru, decam, and cfht all use filter.getId() in their calculation of the singleFilter coadd exposure id. The new FilterLabel does not have a numeric Id, so these mappers will have to be changed. However, I do not know what the time ordering of gen2 removal vs. Filter removal is: if gen2 is removed first, then this won't matter at all.

I did not change this on DM-27170 because I did not want to alter this calculation in gen2 without more discussion, and want to get that ticket finished up.

#### Activity

Hide
Krzysztof Findeisen added a comment -

Pinging this, as it's an indirect blocker for DM-29437.

Show
Krzysztof Findeisen added a comment - Pinging this, as it's an indirect blocker for DM-29437 .
Hide
Lauren MacArthur added a comment -

I'm trying to address this on DM-30284 (no absolute promises on strict backwards-compatibility, but I don't think anybody cares for gen2!) I also have only been looking at obs_lsst and obs_subaru so far, but, presumably, if I do manage to fix those two, any other obs_package will be able to follow(-ish) suit.

Show
Lauren MacArthur added a comment - I'm trying to address this on DM-30284 (no absolute promises on strict backwards-compatibility, but I don't think anybody cares for gen2!) I also have only been looking at obs_lsst and obs_subaru so far, but, presumably, if I do manage to fix those two, any other obs_package will be able to follow(-ish) suit.
Hide
John Parejko added a comment -

Should we close this as "Won't Fix" since it only affects gen2? I think we agreed that we can't remove Filter until we've cut out all the gen2 code, but this is one of the two direct blocker tickets for removing Filter. I was reminded of all this when building meas_algorithms and seeing the huge number of deprecation warnings from Filter.

Show
John Parejko added a comment - Should we close this as "Won't Fix" since it only affects gen2? I think we agreed that we can't remove Filter until we've cut out all the gen2 code, but this is one of the two direct blocker tickets for removing Filter. I was reminded of all this when building meas_algorithms and seeing the huge number of deprecation warnings from Filter.
Hide
Jim Bosch added a comment -

Closing as Won't Fix.

Show
Jim Bosch added a comment - Closing as Won't Fix.
Hide
Krzysztof Findeisen added a comment - - edited

I'm trying to implement DM-27177 and have just run into this issue in obs.lsst.LsstCamBaseMapper._computeCoaddExposureId. How should I handle it? Should I just have _computeCoaddExposureId raise NotImplementedError? Should I remove the if singleFilter block? Hash the filter name?

I have no idea what will break if, for example, the IDs are no longer unique.

Show
Krzysztof Findeisen added a comment - - edited I'm trying to implement DM-27177 and have just run into this issue in obs.lsst.LsstCamBaseMapper._computeCoaddExposureId . How should I handle it? Should I just have _computeCoaddExposureId raise NotImplementedError ? Should I remove the if singleFilter block? Hash the filter name? I have no idea what will break if, for example, the IDs are no longer unique.
Hide
Tim Jenness added a comment -

I'm about to merge DM-34919 (as soon as the jira ticket is marked reviewed) and that will delete this code.

Show
Tim Jenness added a comment - I'm about to merge DM-34919 (as soon as the jira ticket is marked reviewed) and that will delete this code.
Hide
Tim Jenness added a comment -

Krzysztof Findeisen That code should no longer exist.

Show
Tim Jenness added a comment - Krzysztof Findeisen That code should no longer exist.
Hide
Krzysztof Findeisen added a comment -

Confirmed, but I had to deal with something similar in obs_cfht. I took the hash approach; so far it's passing tests.

Show
Krzysztof Findeisen added a comment - Confirmed, but I had to deal with something similar in obs_cfht . I took the hash approach; so far it's passing tests.
Hide
Tim Jenness added a comment -

I also have a ticket in review to remove the code from obs_cfht...

Show
Tim Jenness added a comment - I also have a ticket in review to remove the code from obs_cfht...

#### People

Assignee:
Unassigned
Reporter:
John Parejko
Watchers:
Ian Sullivan, Jim Bosch, John Parejko, Krzysztof Findeisen, Lauren MacArthur, Tim Jenness, Yusra AlSayyad