My understanding of the results of these changes:
- Flags_moveSuccess is true if a point to point move is done and is sufficiently close to the commanded position. It can only be true if the state is enabled/stationary.
- Flags_trackingSuccess indicates that the rotator has finished slewing and is now tracking. It can only be true if the state is enabled/tracking_or_slewing.
These are the flags that the CSC should use to indicate "in position".
I am puzzled why Flags_pt2ptMoveComplete only stays true for 1 second. Is this necessary? Why not treat it like Flags_moveSuccess (but without the "position is close enough" criterion): leave it true until another move begins or some other state change occurs? But it's not very important as long as the CSC can ignore it and use Flags_moveSuccess instead.