Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28341

ingest phosim images into Butler with as-built camera geometry

    XMLWordPrintable

Details

    Description

      We need to update the phosim settings in focalplanelayout.txt and segmentation.txt, to make the phosim images consistent with the as-built camera geometry.

      1/14/21: We will try to solve the inconsistencies between phosim images and real camera geometry by tweaking the phosim repackager first. If that works, we do not need to make changes to phosim itself.

      Completion criteria:

      with a few phosim images, demonstrate that they can be ingested into the butler and accessed via the butler.

      Attachments

        Issue Links

          Activity

            Merged to the  develop branch of ts_analysis_notebooks

            ksuberlak Krzysztof Suberlak added a comment - Merged to the  develop  branch of ts_analysis_notebooks
            bxin Bo Xin [X] (Inactive) added a comment - - edited

            Hi ksuberlak, thanks for the detailed answers above. 

            It is my understanding that imgCloseLoop.py currently works with -inst lsstcam. For -inst comcam and -inst lsst, it is work in progress (we are pretty close to getting them done as well). For comcam, using R22 of lsstcam was a temporary solution. It looks like it is time to get rid of that.

            The intention of this ticket was to enable the packaging and ingestion of PhoSim images in all three modes: comcam, WFS, and FAM. (My bad, I made it clear on the milestones Google doc, but somehow not here on this ticket.) I still think it is important to make sure the minimal pipeline works for all three modes.

            We can either wait for the work on comcam and WFS to finish before we mark this as DONE, or we can create separate tickets for ComCam and WFS. Please let me know what you prefer.

            bxin Bo Xin [X] (Inactive) added a comment - - edited Hi ksuberlak , thanks for the detailed answers above.  It is my understanding that imgCloseLoop.py currently works with -inst lsstcam. For -inst comcam and -inst lsst, it is work in progress (we are pretty close to getting them done as well). For comcam, using R22 of lsstcam was a temporary solution. It looks like it is time to get rid of that. The intention of this ticket was to enable the packaging and ingestion of PhoSim images in all three modes: comcam, WFS, and FAM. (My bad, I made it clear on the milestones Google doc, but somehow not here on this ticket.) I still think it is important to make sure the minimal pipeline works for all three modes. We can either wait for the work on comcam and WFS to finish before we mark this as DONE, or we can create separate tickets for ComCam and WFS. Please let me know what you prefer.

            Currently, the AOS pipeline uses gen2, and as such it allows ingestion of lsstCam only. The corner sensors are included in the `data/lsst` segmentation file for phosim, so both FAM and WFS can be correctly generated.  I am also working on   DM-29264  which   will update `data/comcam`  in phosim.  I have tested the  ingest  with gen3 butler and it works with lsstCam and lsstComCam (as comCam is called in obs_lsst). I made few changes in obs_lsst to enable using the proper translator and  I am working on  a PR to enable boresight calculation. With that, gen3 butler can use the gain from  mapper information to do the ISR successfully with "doApplyGains: True" setting (i.e. not having to use "fake flats" at all).  So perhaps we could close this ticket as showing comcam ingestion with current AOS pipeline (gen2), while open a new ticket with gen3 ingestion of comcam, lsstcam, and corner sensors.

            ksuberlak Krzysztof Suberlak added a comment - Currently, the AOS pipeline uses gen2, and as such it allows ingestion of lsstCam only. The corner sensors are included in the `data/lsst` segmentation file for phosim, so both FAM and WFS can be correctly generated.  I am also working on    DM-29264   which   will update `data/comcam`  in phosim.  I have tested the  ingest  with gen3 butler and it works with lsstCam and lsstComCam (as comCam is called in obs_lsst). I made few changes in obs_lsst to enable using the proper translator and  I am working on  a PR to enable boresight calculation. With that, gen3 butler can use the gain from  mapper information to do the ISR successfully with "doApplyGains: True" setting (i.e. not having to use "fake flats" at all).  So perhaps we could close this ticket as showing comcam ingestion with current AOS pipeline (gen2), while open a new ticket with gen3 ingestion of comcam, lsstcam, and corner sensors.

            Per discussion above, we are closing this ticket.

            The extension work is being tracked in DM-29356 - gen3 ingestion of PhoSim images for comcam, lsstcam, and corner sensors. Thanks!

            bxin Bo Xin [X] (Inactive) added a comment - Per discussion above, we are closing this ticket. The extension work is being tracked in  DM-29356 - gen3 ingestion of PhoSim images for comcam, lsstcam, and corner sensors. Thanks!

            Marking as done

            ksuberlak Krzysztof Suberlak added a comment - Marking as done

            People

              ksuberlak Krzysztof Suberlak
              bxin Bo Xin [X] (Inactive)
              Bo Xin [X] (Inactive)
              Bo Xin [X] (Inactive), Bryce Kalmbach, Krzysztof Suberlak
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.