Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_aos
-
Labels:
-
Story Points:10
-
Epic Link:
-
Team:Telescope and Site
-
Urgent?:No
Description
We need to make WEP code part of the DM standard CI.
All the changes proposed in https://tstn-026.lsst.io need to be implemented (as of 1/14/21 these are still on a branch and to be reviewed).
This is a high priority because we need to get this up running before we tackle other image processing challenges.
It is expected that Tiago Ribeiro will lead the effort to set up the new architecture (Tiago's ticket DM-28520). Bryce, with assistance from Te-Wei Tsai, will lead in migrating the existing code into the new architecture.
Completion criteria:
The CI job takes images from butler, calculates the WF for each CCD center, and compares solutions to PhoSim truth.
A mechanism needs to be set up for monitoring the wavefront RMS error with each code change.
Attachments
Issue Links
- is parent task of
-
- Done
Activity
Merged template generation from model code into ts_wep: https://github.com/lsst-ts/ts_wep/releases/tag/v1.5.1
Merged template generation from phosim code into ts_wep: https://github.com/lsst-ts/ts_wep/releases/tag/v1.5.3
Notebook with work in progress on Gen 3 Wavefront Estimation Pipeline: https://github.com/lsst-ts/ts_analysis_notebooks/pull/4
As discussed with Tiago Ribeiro we agree to review this ticket recognizing that it acheived the following goals:
- Creation of the pipeline task
- Set up the Continuous integration.
However, the integration of the this pipeline task into the DM stack CI will be tracked in another ticket.
Sandrine Thomas
added a comment - As discussed with Tiago Ribeiro we agree to review this ticket recognizing that it acheived the following goals:
Creation of the pipeline task
Set up the Continuous integration.
However, the integration of the this pipeline task into the DM stack CI will be tracked in another ticket. Tiago Ribeiro, Have you had time to review this ticket? Thanks!
Sandrine Thomas
added a comment - Tiago Ribeiro , Have you had time to review this ticket? Thanks! Tiago Ribeiro, Could you review this ticket so we can close it?
Sandrine Thomas
added a comment - Tiago Ribeiro , Could you review this ticket so we can close it? Pipeline tasks are software abstractions that represents how data is processed using the DM stack. This allows one to develop data processing steps that takes fully advantage of the Vera Rubin Science Pipelines, which includes, accessing data through the butler, parallelization, access to other pipelines tasks and much more. For example, when developing a pipeline task to process data, one can integrate steps that will also perform Instrument Signal Removal (ISR) using the standard routines.
An initial version of the wep pipeline task was created, thus integrating the wavefront estivation pipeline with the DM stack. The pipeline was used to process phosim simulated data and also integrated with the MTAOS CSC.
Merged new centroid finding algorithm CentroidConvolveTemplate into ts_wep: https://github.com/lsst-ts/ts_wep/pull/58