# Deprecate validate_drp

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
0.2
• Team:
Architecture
• Urgent?:
No

#### Description

The faro package will now replace validate_drp for computing metrics. Faro includes all metrics currently in validate_drp and more. Remaining metrics will be implemented in faro.

validate_drp should be deprecated (but not removed). It may continue to be useful until gen2 middleware is deprecated.

#### Activity

Hide
John Parejko added a comment -

Is this still planned to happen? I've been catching references to validate_drp in various places as I work on removing references to validation_data_hsc and validation_data_decam per RFC-815. Might be good to get those cleaned up at about the same time as I do that. First new years RFC?

Show
John Parejko added a comment - Is this still planned to happen? I've been catching references to validate_drp in various places as I work on removing references to validation_data_hsc and validation_data_decam per RFC-815 . Might be good to get those cleaned up at about the same time as I do that. First new years RFC?
Hide
Leanne Guy added a comment -

Yes it is. I understood that it was still being used by the pipelines team for Gen2/3 parity testing Once that is signed off we can do this.

Show
Leanne Guy added a comment - Yes it is. I understood that it was still being used by the pipelines team for Gen2/3 parity testing Once that is signed off we can do this.
Hide
Tim Jenness added a comment -

Keith Bechtol / Jeffrey Carlin I've asked you both to review because I'm not sure whether either of you are around. This was a simple change to lsst_distrib and faro but I took the opportunity of cleaning up the faro tests so that they find the data files relative to the tests themselves without having to use getPackageDir.

Show
Tim Jenness added a comment - Keith Bechtol / Jeffrey Carlin I've asked you both to review because I'm not sure whether either of you are around. This was a simple change to lsst_distrib and faro but I took the opportunity of cleaning up the faro tests so that they find the data files relative to the tests themselves without having to use getPackageDir.
Hide
Tim Jenness added a comment -

I see that validate_drp is mentioned as a label in make_job_document.py – does that stay the same because you want continuity in labeling in SQuaSH or should it change to "faro"?

I also don't know if you want to change the connections.package entries in the pipeline YAML files:

  config:  connections.package: validate_drp 

Show
Tim Jenness added a comment - I see that validate_drp is mentioned as a label in make_job_document.py – does that stay the same because you want continuity in labeling in SQuaSH or should it change to "faro"? I also don't know if you want to change the connections.package entries in the pipeline YAML files: config: connections.package: validate_drp
Hide
Keith Bechtol added a comment -

Thank you. Looks good.

Show
Keith Bechtol added a comment - Thank you. Looks good.
Hide
Tim Jenness added a comment -

There is one mention of validate_drp in the dev guide: https://developer.lsst.io/services/software.html?highlight=validate_drp#validation-test-data-sets

I don't really know what to put in there instead so I've left it for now. It looks like it might be more out of date than just mentioning validate_drp so I'll file a ticket.

Show
Tim Jenness added a comment - There is one mention of validate_drp in the dev guide: https://developer.lsst.io/services/software.html?highlight=validate_drp#validation-test-data-sets I don't really know what to put in there instead so I've left it for now. It looks like it might be more out of date than just mentioning validate_drp so I'll file a ticket.
Hide
Keith Bechtol added a comment -

Thanks. I see the new ticket: https://jira.lsstcorp.org/browse/DM-34160

Agree that clean up might take a bit more thought.

Show
Keith Bechtol added a comment - Thanks. I see the new ticket: https://jira.lsstcorp.org/browse/DM-34160 Agree that clean up might take a bit more thought.
Hide
John Parejko added a comment -

For that dev guide section, note that the HSC and DECAM validation_data packages are deprecated: RFC-815

validation_data_cfht has been updated to gen3 and is used to generate a testdata_jointcal dataset.

Show
John Parejko added a comment - For that dev guide section, note that the HSC and DECAM validation_data packages are deprecated: RFC-815 validation_data_cfht has been updated to gen3 and is used to generate a testdata_jointcal dataset.

#### People

Assignee:
Tim Jenness
Reporter:
Leanne Guy
Reviewers:
Keith Bechtol
Watchers:
Jeffrey Carlin, John Parejko, Keith Bechtol, Leanne Guy, Tim Jenness
0 Vote for this issue
Watchers:
5 Start watching this issue

#### Dates

Due:
Created:
Updated:
Resolved:

#### Jenkins

No builds found.