Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28362

Continue to test the ability of the camera cable wrap to follow the rotator

    XMLWordPrintable

    Details

      Description

      Continue to test the MTMount CSC's ability to make the CCW track the rotator. This is the continuation of DM-28215 for the next sprint.

        Attachments

          Issue Links

          is child task of

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. CAP-667 Catch-all for T&S tickets for ts_xml 8 (formerly 7.2)

          • Undefined - No priority assigned (may not apply or be unknown)
          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28215 Test the ability of the camera cable wrap to follow the rotator

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Pull requests:

            Show
            rowen Russell Owen added a comment - - edited Pull requests: https://github.com/lsst-ts/ts_MTMount/pull/36 https://github.com/lsst-ts/ts_MTMount/pull/37 cherry-pick the changes from the ccw_only branch to develop https://github.com/lsst-ts/ts_idl/pull/52 https://github.com/lsst-ts/ts_xml/pull/399 https://github.com/lsst-ts/ts_simactuators/pull/11 (already reviewed, merged and released)
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Eric Coughlin has already reviewed the ts_simactuators pull request and I merged it and released v2.2.0.
            Tiago Ribeiro please review the other pull requests. The two MTMount pull requests primarily differ in whether they are based off of develop (u/rowen/DM-28362) or ccw_only (tickets/DM-28362). One is mostly cherry-picked from the other. I suggest reviewing one of those two pull requests carefully and then examining the difference between the two branches in something like SourceTree to see what is different between the two (not a lot).

            Show
            rowen Russell Owen added a comment - - edited Eric Coughlin has already reviewed the ts_simactuators pull request and I merged it and released v2.2.0. Tiago Ribeiro please review the other pull requests. The two MTMount pull requests primarily differ in whether they are based off of develop (u/rowen/ DM-28362 ) or ccw_only (tickets/ DM-28362 ). One is mostly cherry-picked from the other. I suggest reviewing one of those two pull requests carefully and then examining the difference between the two branches in something like SourceTree to see what is different between the two (not a lot).
            Hide
            Permalink
            tribeiro Tiago Ribeiro added a comment -

            Code reviewed in GitHub. Overall looks good. I made some comments in line I hope you will consider before merging.

            Show
            tribeiro Tiago Ribeiro added a comment - Code reviewed in GitHub. Overall looks good. I made some comments in line I hope you will consider before merging.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Thank you for a very helpful review. I implemented many of your requested changes and answered all your comments.

            I will hold off tagging the new ts_MTMount until ts_xml 7.2 is released.

            Show
            rowen Russell Owen added a comment - Thank you for a very helpful review. I implemented many of your requested changes and answered all your comments. I will hold off tagging the new ts_MTMount until ts_xml 7.2 is released.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Tiago Ribeiro
              Watchers:
              Russell Owen, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.