Added a few minor style comments to the obs_subaru PR. Effectively the same things apply to obs_cfht; I'm not going to bother to re-list them there.
I'm sceptical of the value of checking the values of numbers in the obs package tests. This just means that the numbers are going to have to be changed twice whenever they need to be updated – what is this buying us?
Testing that "that the... config override loads correctly" seems a bit vague to me. I think you're basically doing what Russell Owen was looking for, but maybe he can confirm – perhaps he actually wanted you to instantiate a command line task or something?
I think the tests in pipe_tasks are pretty much what we're looking for. I've not carefully checked the colorterms code (or run a coverage tool) to make sure there are no major code paths being missed, but this certainly looks reasonable.
However, I do think you should revisit the code in testPhotoCal.py. There's a lot of duplication between the old PhotoCalTest.test1 and PhotoCalTest.testColorTerms. A little bit of refactoring here could clean things up a lot. It would also be helpful to add some comments describing what it is you're testing and why you're getting the results you expect.