Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28391

Update pipe_analysis scripts for new API in treecorr

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_analysis
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP S21a (Dec Jan)
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      The scripts in pipe_analysis are currently failing, apparently due to an API change in treecorr's GGCorrelation object:

      AttributeError: 'GGCorrelation' object has no attribute 'varxi'
      

      Update the scripts to the new API, which now has varxip and varxim attributes, which, according to the documentation represent the variances of xip (the real part of xi+) and xim (the real part of xi-), respectively.

        Attachments

          Activity

          Hide
          lauren Lauren MacArthur added a comment -

          Would you mind giving this a look?  I took a guess as to which of the new variance parameters should be used now that the one that was being used no longer exists.  I see some differences between my current run:

          and that of RC2 w_2021_02

          But perhaps that is to be expected (and a desired/more correct result)?

          I also took the opportunity to fix up some Matplotlib deprecation warnings in a separate commit.

          Show
          lauren Lauren MacArthur added a comment - Would you mind giving this a look?  I took a guess as to which of the new variance parameters should be used now that the one that was being used no longer exists.  I see some differences between my current run: and that of RC2 w_2021_02 But perhaps that is to be expected (and a desired/more correct result)? I also took the opportunity to fix up some Matplotlib deprecation warnings in a separate commit.
          Hide
          lauren Lauren MacArthur added a comment -

          Hasn't seemed to show up yet...PR is https://github.com/lsst-dm/pipe_analysis/pull/70

          Show
          lauren Lauren MacArthur added a comment - Hasn't seemed to show up yet...PR is  https://github.com/lsst-dm/pipe_analysis/pull/70
          Hide
          kannawad Arun Kannawadi added a comment -

          In the above plots, for the points where the marker is filled, the errorbars were definitely correct prior to the review. So the variation in their sizes comes from changes in processing. It is hard to have good intuition on uncertainy when the yscale is log unfortunately.

          Show
          kannawad Arun Kannawadi added a comment - In the above plots, for the points where the marker is filled, the errorbars were definitely correct prior to the review. So the variation in their sizes comes from changes in processing. It is hard to have good intuition on uncertainy when the yscale is log unfortunately.
          Hide
          lauren Lauren MacArthur added a comment -

          Indeed!  Thanks for the review.  Merged and done.

          Show
          lauren Lauren MacArthur added a comment - Indeed!  Thanks for the review.  Merged and done.

            People

            Assignee:
            lauren Lauren MacArthur
            Reporter:
            lauren Lauren MacArthur
            Reviewers:
            Arun Kannawadi
            Watchers:
            Arun Kannawadi, Lauren MacArthur
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.