Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28459

Bands seem wrong for LATISS in butler

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None
    • Story Points:
      3
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      I just glanced at the physical_filter / band mappings in gen3 butler and I get the following:

      instrument              name                          band            
      ---------- ----------------------------- -----------------------------
          LATISS                          BG40                          BG40
          LATISS                    BG40~empty                    BG40~empty
          LATISS                     BG40~none                     BG40~none
          LATISS            BG40~ronchi170lpmm            BG40~ronchi170lpmm
          LATISS             BG40~ronchi90lpmm             BG40~ronchi90lpmm
          LATISS                  BG40~unknown                  BG40~unknown
          LATISS               KPNO_1111_436nm                             g
          LATISS         KPNO_1111_436nm~empty         KPNO_1111_436nm~empty
          LATISS          KPNO_1111_436nm~none          KPNO_1111_436nm~none
          LATISS KPNO_1111_436nm~ronchi170lpmm KPNO_1111_436nm~ronchi170lpmm
          LATISS  KPNO_1111_436nm~ronchi90lpmm  KPNO_1111_436nm~ronchi90lpmm
          LATISS       KPNO_1111_436nm~unknown       KPNO_1111_436nm~unknown
          LATISS               KPNO_373A_677nm                             r
          LATISS         KPNO_373A_677nm~empty         KPNO_373A_677nm~empty
          LATISS          KPNO_373A_677nm~none          KPNO_373A_677nm~none
          LATISS KPNO_373A_677nm~ronchi170lpmm KPNO_373A_677nm~ronchi170lpmm
          LATISS  KPNO_373A_677nm~ronchi90lpmm  KPNO_373A_677nm~ronchi90lpmm
          LATISS       KPNO_373A_677nm~unknown       KPNO_373A_677nm~unknown
          LATISS                KPNO_406_828nm                             z
          LATISS          KPNO_406_828nm~empty          KPNO_406_828nm~empty
          LATISS           KPNO_406_828nm~none           KPNO_406_828nm~none
          LATISS  KPNO_406_828nm~ronchi170lpmm  KPNO_406_828nm~ronchi170lpmm
          LATISS   KPNO_406_828nm~ronchi90lpmm   KPNO_406_828nm~ronchi90lpmm
          LATISS        KPNO_406_828nm~unknown        KPNO_406_828nm~unknown
          LATISS                         RG610                         RG610
          LATISS                   RG610~empty                   RG610~empty
          LATISS                    RG610~none                    RG610~none
          LATISS           RG610~ronchi170lpmm           RG610~ronchi170lpmm
          LATISS            RG610~ronchi90lpmm            RG610~ronchi90lpmm
          LATISS                 RG610~unknown                 RG610~unknown
          LATISS                blank_bk7_wg05                blank_bk7_wg05
          LATISS          blank_bk7_wg05~empty          blank_bk7_wg05~empty
          LATISS           blank_bk7_wg05~none           blank_bk7_wg05~none
          LATISS  blank_bk7_wg05~ronchi170lpmm  blank_bk7_wg05~ronchi170lpmm
          LATISS   blank_bk7_wg05~ronchi90lpmm   blank_bk7_wg05~ronchi90lpmm
          LATISS        blank_bk7_wg05~unknown        blank_bk7_wg05~unknown
          LATISS                      diffuser                      diffuser
          LATISS                diffuser~empty                diffuser~empty
          LATISS                 diffuser~none                 diffuser~none
          LATISS        diffuser~ronchi170lpmm        diffuser~ronchi170lpmm
          LATISS         diffuser~ronchi90lpmm         diffuser~ronchi90lpmm
          LATISS              diffuser~unknown              diffuser~unknown
          LATISS                         empty                         empty
          LATISS                   empty~empty                   empty~empty
          LATISS                    empty~none                    empty~none
          LATISS           empty~ronchi170lpmm           empty~ronchi170lpmm
          LATISS            empty~ronchi90lpmm            empty~ronchi90lpmm
          LATISS                 empty~unknown                 empty~unknown
          LATISS                    quadnotch1                    quadnotch1
          LATISS              quadnotch1~empty              quadnotch1~empty
          LATISS               quadnotch1~none               quadnotch1~none
          LATISS      quadnotch1~ronchi170lpmm      quadnotch1~ronchi170lpmm
          LATISS       quadnotch1~ronchi90lpmm       quadnotch1~ronchi90lpmm
          LATISS            quadnotch1~unknown            quadnotch1~unknown
          LATISS                       unknown                       unknown
          LATISS                 unknown~empty                 unknown~empty
          LATISS                  unknown~none                  unknown~none
          LATISS         unknown~ronchi170lpmm         unknown~ronchi170lpmm
          LATISS          unknown~ronchi90lpmm          unknown~ronchi90lpmm
          LATISS               unknown~unknown               unknown~unknown
      

      This seems very very wrong to me. We have KPNO_406_828nm as z but we also have KPNO_406_828nm~empty being something completely different when surely that is also meant to be "z" ? And at the very least for "KPNO_406_828nm~ronchi170lpmm" shouldn't the band be "z~something" or just "z" since presumably it is still z-band. The physical filter name should never turn up in the band.

        Attachments

          Issue Links

            Activity

            Hide
            pingraham Patrick Ingraham added a comment -

            Correct, the diffuser was for lab testing. Essentially ancient history. 

            Show
            pingraham Patrick Ingraham added a comment - Correct, the diffuser was for lab testing. Essentially ancient history. 
            Hide
            tjenness Tim Jenness added a comment -

            Merlin Fisher-Levine I've updated the band calculation and cleaned it up a bit to now assume that bands do not have to be unique.

            The current LSSTCam result is now:

               LSSTCam                         480nm        g
               LSSTCam               480nm~ND_OD0.01     g~nd
               LSSTCam               480nm~ND_OD0.05     g~nd
               LSSTCam                480nm~ND_OD0.1     g~nd
               LSSTCam                480nm~ND_OD0.3     g~nd
               LSSTCam                480nm~ND_OD0.4     g~nd
               LSSTCam                480nm~ND_OD0.5     g~nd
               LSSTCam                480nm~ND_OD0.7     g~nd
               LSSTCam                480nm~ND_OD1.0     g~nd
               LSSTCam                480nm~ND_OD2.0     g~nd
               LSSTCam                480nm~ND_OD3.0     g~nd
               LSSTCam                480nm~ND_OD4.0     g~nd
               LSSTCam                         650nm        r
               LSSTCam               650nm~ND_OD0.01     r~nd
               LSSTCam               650nm~ND_OD0.05     r~nd
               LSSTCam                650nm~ND_OD0.1     r~nd
               LSSTCam                650nm~ND_OD0.3     r~nd
               LSSTCam                650nm~ND_OD0.4     r~nd
               LSSTCam                650nm~ND_OD0.5     r~nd
               LSSTCam                650nm~ND_OD0.7     r~nd
               LSSTCam                650nm~ND_OD1.0     r~nd
               LSSTCam                650nm~ND_OD2.0     r~nd
               LSSTCam                650nm~ND_OD3.0     r~nd
               LSSTCam                650nm~ND_OD4.0     r~nd
               LSSTCam                         750nm        i
               LSSTCam               750nm~ND_OD0.01     i~nd
               LSSTCam               750nm~ND_OD0.05     i~nd
               LSSTCam                750nm~ND_OD0.1     i~nd
               LSSTCam                750nm~ND_OD0.3     i~nd
               LSSTCam                750nm~ND_OD0.4     i~nd
               LSSTCam                750nm~ND_OD0.5     i~nd
               LSSTCam                750nm~ND_OD0.7     i~nd
               LSSTCam                750nm~ND_OD1.0     i~nd
               LSSTCam                750nm~ND_OD2.0     i~nd
               LSSTCam                750nm~ND_OD3.0     i~nd
               LSSTCam                750nm~ND_OD4.0     i~nd
               LSSTCam                         870nm        z
               LSSTCam               870nm~ND_OD0.01     z~nd
               LSSTCam               870nm~ND_OD0.05     z~nd
               LSSTCam                870nm~ND_OD0.1     z~nd
               LSSTCam                870nm~ND_OD0.3     z~nd
               LSSTCam                870nm~ND_OD0.4     z~nd
               LSSTCam                870nm~ND_OD0.5     z~nd
               LSSTCam                870nm~ND_OD0.7     z~nd
               LSSTCam                870nm~ND_OD1.0     z~nd
               LSSTCam                870nm~ND_OD2.0     z~nd
               LSSTCam                870nm~ND_OD3.0     z~nd
               LSSTCam                870nm~ND_OD4.0     z~nd
               LSSTCam                         950nm        y
               LSSTCam               950nm~ND_OD0.01     y~nd
               LSSTCam               950nm~ND_OD0.05     y~nd
               LSSTCam                950nm~ND_OD0.1     y~nd
               LSSTCam                950nm~ND_OD0.3     y~nd
               LSSTCam                950nm~ND_OD0.4     y~nd
               LSSTCam                950nm~ND_OD0.5     y~nd
               LSSTCam                950nm~ND_OD0.7     y~nd
               LSSTCam                950nm~ND_OD1.0     y~nd
               LSSTCam                950nm~ND_OD2.0     y~nd
               LSSTCam                950nm~ND_OD3.0     y~nd
               LSSTCam                950nm~ND_OD4.0     y~nd
               LSSTCam                         970nm        y
               LSSTCam               970nm~ND_OD0.01     y~nd
               LSSTCam               970nm~ND_OD0.05     y~nd
               LSSTCam                970nm~ND_OD0.1     y~nd
               LSSTCam                970nm~ND_OD0.3     y~nd
               LSSTCam                970nm~ND_OD0.4     y~nd
               LSSTCam                970nm~ND_OD0.5     y~nd
               LSSTCam                970nm~ND_OD0.7     y~nd
               LSSTCam                970nm~ND_OD1.0     y~nd
               LSSTCam                970nm~ND_OD2.0     y~nd
               LSSTCam                970nm~ND_OD3.0     y~nd
               LSSTCam                970nm~ND_OD4.0     y~nd
               LSSTCam                     ND_OD0.01 white~nd
               LSSTCam                     ND_OD0.05 white~nd
               LSSTCam                      ND_OD0.1 white~nd
               LSSTCam                      ND_OD0.3 white~nd
               LSSTCam                      ND_OD0.4 white~nd
               LSSTCam                      ND_OD0.5 white~nd
               LSSTCam                      ND_OD0.7 white~nd
               LSSTCam                      ND_OD1.0 white~nd
               LSSTCam                      ND_OD2.0 white~nd
               LSSTCam                      ND_OD3.0 white~nd
               LSSTCam                      ND_OD4.0 white~nd
               LSSTCam                         SDSSY        y
               LSSTCam               SDSSY~ND_OD0.01     y~nd
               LSSTCam               SDSSY~ND_OD0.05     y~nd
               LSSTCam                SDSSY~ND_OD0.1     y~nd
               LSSTCam                SDSSY~ND_OD0.3     y~nd
               LSSTCam                SDSSY~ND_OD0.4     y~nd
               LSSTCam                SDSSY~ND_OD0.5     y~nd
               LSSTCam                SDSSY~ND_OD0.7     y~nd
               LSSTCam                SDSSY~ND_OD1.0     y~nd
               LSSTCam                SDSSY~ND_OD2.0     y~nd
               LSSTCam                SDSSY~ND_OD3.0     y~nd
               LSSTCam                SDSSY~ND_OD4.0     y~nd
               LSSTCam                         SDSSg        g
               LSSTCam               SDSSg~ND_OD0.01     g~nd
               LSSTCam               SDSSg~ND_OD0.05     g~nd
               LSSTCam                SDSSg~ND_OD0.1     g~nd
               LSSTCam                SDSSg~ND_OD0.3     g~nd
               LSSTCam                SDSSg~ND_OD0.4     g~nd
               LSSTCam                SDSSg~ND_OD0.5     g~nd
               LSSTCam                SDSSg~ND_OD0.7     g~nd
               LSSTCam                SDSSg~ND_OD1.0     g~nd
               LSSTCam                SDSSg~ND_OD2.0     g~nd
               LSSTCam                SDSSg~ND_OD3.0     g~nd
               LSSTCam                SDSSg~ND_OD4.0     g~nd
               LSSTCam                         SDSSi        i
               LSSTCam               SDSSi~ND_OD0.01     i~nd
               LSSTCam               SDSSi~ND_OD0.05     i~nd
               LSSTCam                SDSSi~ND_OD0.1     i~nd
               LSSTCam                SDSSi~ND_OD0.3     i~nd
               LSSTCam                SDSSi~ND_OD0.4     i~nd
               LSSTCam                SDSSi~ND_OD0.5     i~nd
               LSSTCam                SDSSi~ND_OD0.7     i~nd
               LSSTCam                SDSSi~ND_OD1.0     i~nd
               LSSTCam                SDSSi~ND_OD2.0     i~nd
               LSSTCam                SDSSi~ND_OD3.0     i~nd
               LSSTCam                SDSSi~ND_OD4.0     i~nd
               LSSTCam                         SDSSr        r
               LSSTCam               SDSSr~ND_OD0.01     r~nd
               LSSTCam               SDSSr~ND_OD0.05     r~nd
               LSSTCam                SDSSr~ND_OD0.1     r~nd
               LSSTCam                SDSSr~ND_OD0.3     r~nd
               LSSTCam                SDSSr~ND_OD0.4     r~nd
               LSSTCam                SDSSr~ND_OD0.5     r~nd
               LSSTCam                SDSSr~ND_OD0.7     r~nd
               LSSTCam                SDSSr~ND_OD1.0     r~nd
               LSSTCam                SDSSr~ND_OD2.0     r~nd
               LSSTCam                SDSSr~ND_OD3.0     r~nd
               LSSTCam                SDSSr~ND_OD4.0     r~nd
               LSSTCam                         SDSSu        u
               LSSTCam               SDSSu~ND_OD0.01     u~nd
               LSSTCam               SDSSu~ND_OD0.05     u~nd
               LSSTCam                SDSSu~ND_OD0.1     u~nd
               LSSTCam                SDSSu~ND_OD0.3     u~nd
               LSSTCam                SDSSu~ND_OD0.4     u~nd
               LSSTCam                SDSSu~ND_OD0.5     u~nd
               LSSTCam                SDSSu~ND_OD0.7     u~nd
               LSSTCam                SDSSu~ND_OD1.0     u~nd
               LSSTCam                SDSSu~ND_OD2.0     u~nd
               LSSTCam                SDSSu~ND_OD3.0     u~nd
               LSSTCam                SDSSu~ND_OD4.0     u~nd
               LSSTCam                         SDSSz        z
               LSSTCam               SDSSz~ND_OD0.01     z~nd
               LSSTCam               SDSSz~ND_OD0.05     z~nd
               LSSTCam                SDSSz~ND_OD0.1     z~nd
               LSSTCam                SDSSz~ND_OD0.3     z~nd
               LSSTCam                SDSSz~ND_OD0.4     z~nd
               LSSTCam                SDSSz~ND_OD0.5     z~nd
               LSSTCam                SDSSz~ND_OD0.7     z~nd
               LSSTCam                SDSSz~ND_OD1.0     z~nd
               LSSTCam                SDSSz~ND_OD2.0     z~nd
               LSSTCam                SDSSz~ND_OD3.0     z~nd
               LSSTCam                SDSSz~ND_OD4.0     z~nd
               LSSTCam                         empty    white
               LSSTCam                             g        g
               LSSTCam                          grid     grid
               LSSTCam                grid~ND_OD0.01  grid~nd
               LSSTCam                grid~ND_OD0.05  grid~nd
               LSSTCam                 grid~ND_OD0.1  grid~nd
               LSSTCam                 grid~ND_OD0.3  grid~nd
               LSSTCam                 grid~ND_OD0.4  grid~nd
               LSSTCam                 grid~ND_OD0.5  grid~nd
               LSSTCam                 grid~ND_OD0.7  grid~nd
               LSSTCam                 grid~ND_OD1.0  grid~nd
               LSSTCam                 grid~ND_OD2.0  grid~nd
               LSSTCam                 grid~ND_OD3.0  grid~nd
               LSSTCam                 grid~ND_OD4.0  grid~nd
               LSSTCam                             i        i
               LSSTCam                             r        r
               LSSTCam                          spot     spot
               LSSTCam                spot~ND_OD0.01  spot~nd
               LSSTCam                spot~ND_OD0.05  spot~nd
               LSSTCam                 spot~ND_OD0.1  spot~nd
               LSSTCam                 spot~ND_OD0.3  spot~nd
               LSSTCam                 spot~ND_OD0.4  spot~nd
               LSSTCam                 spot~ND_OD0.5  spot~nd
               LSSTCam                 spot~ND_OD0.7  spot~nd
               LSSTCam                 spot~ND_OD1.0  spot~nd
               LSSTCam                 spot~ND_OD2.0  spot~nd
               LSSTCam                 spot~ND_OD3.0  spot~nd
               LSSTCam                 spot~ND_OD4.0  spot~nd
               LSSTCam                             u        u
               LSSTCam                       unknown  unknown
               LSSTCam                             y        y
               LSSTCam                             z        z
            

            I fixed the blank->white issue as well.

            This change required that I make a small change to obs_base to make it handle afwFilter duplication a bit better. That is for deprecated code so I hope it's not contentious.

            Show
            tjenness Tim Jenness added a comment - Merlin Fisher-Levine I've updated the band calculation and cleaned it up a bit to now assume that bands do not have to be unique. The current LSSTCam result is now: LSSTCam 480nm g LSSTCam 480nm~ND_OD0.01 g~nd LSSTCam 480nm~ND_OD0.05 g~nd LSSTCam 480nm~ND_OD0.1 g~nd LSSTCam 480nm~ND_OD0.3 g~nd LSSTCam 480nm~ND_OD0.4 g~nd LSSTCam 480nm~ND_OD0.5 g~nd LSSTCam 480nm~ND_OD0.7 g~nd LSSTCam 480nm~ND_OD1.0 g~nd LSSTCam 480nm~ND_OD2.0 g~nd LSSTCam 480nm~ND_OD3.0 g~nd LSSTCam 480nm~ND_OD4.0 g~nd LSSTCam 650nm r LSSTCam 650nm~ND_OD0.01 r~nd LSSTCam 650nm~ND_OD0.05 r~nd LSSTCam 650nm~ND_OD0.1 r~nd LSSTCam 650nm~ND_OD0.3 r~nd LSSTCam 650nm~ND_OD0.4 r~nd LSSTCam 650nm~ND_OD0.5 r~nd LSSTCam 650nm~ND_OD0.7 r~nd LSSTCam 650nm~ND_OD1.0 r~nd LSSTCam 650nm~ND_OD2.0 r~nd LSSTCam 650nm~ND_OD3.0 r~nd LSSTCam 650nm~ND_OD4.0 r~nd LSSTCam 750nm i LSSTCam 750nm~ND_OD0.01 i~nd LSSTCam 750nm~ND_OD0.05 i~nd LSSTCam 750nm~ND_OD0.1 i~nd LSSTCam 750nm~ND_OD0.3 i~nd LSSTCam 750nm~ND_OD0.4 i~nd LSSTCam 750nm~ND_OD0.5 i~nd LSSTCam 750nm~ND_OD0.7 i~nd LSSTCam 750nm~ND_OD1.0 i~nd LSSTCam 750nm~ND_OD2.0 i~nd LSSTCam 750nm~ND_OD3.0 i~nd LSSTCam 750nm~ND_OD4.0 i~nd LSSTCam 870nm z LSSTCam 870nm~ND_OD0.01 z~nd LSSTCam 870nm~ND_OD0.05 z~nd LSSTCam 870nm~ND_OD0.1 z~nd LSSTCam 870nm~ND_OD0.3 z~nd LSSTCam 870nm~ND_OD0.4 z~nd LSSTCam 870nm~ND_OD0.5 z~nd LSSTCam 870nm~ND_OD0.7 z~nd LSSTCam 870nm~ND_OD1.0 z~nd LSSTCam 870nm~ND_OD2.0 z~nd LSSTCam 870nm~ND_OD3.0 z~nd LSSTCam 870nm~ND_OD4.0 z~nd LSSTCam 950nm y LSSTCam 950nm~ND_OD0.01 y~nd LSSTCam 950nm~ND_OD0.05 y~nd LSSTCam 950nm~ND_OD0.1 y~nd LSSTCam 950nm~ND_OD0.3 y~nd LSSTCam 950nm~ND_OD0.4 y~nd LSSTCam 950nm~ND_OD0.5 y~nd LSSTCam 950nm~ND_OD0.7 y~nd LSSTCam 950nm~ND_OD1.0 y~nd LSSTCam 950nm~ND_OD2.0 y~nd LSSTCam 950nm~ND_OD3.0 y~nd LSSTCam 950nm~ND_OD4.0 y~nd LSSTCam 970nm y LSSTCam 970nm~ND_OD0.01 y~nd LSSTCam 970nm~ND_OD0.05 y~nd LSSTCam 970nm~ND_OD0.1 y~nd LSSTCam 970nm~ND_OD0.3 y~nd LSSTCam 970nm~ND_OD0.4 y~nd LSSTCam 970nm~ND_OD0.5 y~nd LSSTCam 970nm~ND_OD0.7 y~nd LSSTCam 970nm~ND_OD1.0 y~nd LSSTCam 970nm~ND_OD2.0 y~nd LSSTCam 970nm~ND_OD3.0 y~nd LSSTCam 970nm~ND_OD4.0 y~nd LSSTCam ND_OD0.01 white~nd LSSTCam ND_OD0.05 white~nd LSSTCam ND_OD0.1 white~nd LSSTCam ND_OD0.3 white~nd LSSTCam ND_OD0.4 white~nd LSSTCam ND_OD0.5 white~nd LSSTCam ND_OD0.7 white~nd LSSTCam ND_OD1.0 white~nd LSSTCam ND_OD2.0 white~nd LSSTCam ND_OD3.0 white~nd LSSTCam ND_OD4.0 white~nd LSSTCam SDSSY y LSSTCam SDSSY~ND_OD0.01 y~nd LSSTCam SDSSY~ND_OD0.05 y~nd LSSTCam SDSSY~ND_OD0.1 y~nd LSSTCam SDSSY~ND_OD0.3 y~nd LSSTCam SDSSY~ND_OD0.4 y~nd LSSTCam SDSSY~ND_OD0.5 y~nd LSSTCam SDSSY~ND_OD0.7 y~nd LSSTCam SDSSY~ND_OD1.0 y~nd LSSTCam SDSSY~ND_OD2.0 y~nd LSSTCam SDSSY~ND_OD3.0 y~nd LSSTCam SDSSY~ND_OD4.0 y~nd LSSTCam SDSSg g LSSTCam SDSSg~ND_OD0.01 g~nd LSSTCam SDSSg~ND_OD0.05 g~nd LSSTCam SDSSg~ND_OD0.1 g~nd LSSTCam SDSSg~ND_OD0.3 g~nd LSSTCam SDSSg~ND_OD0.4 g~nd LSSTCam SDSSg~ND_OD0.5 g~nd LSSTCam SDSSg~ND_OD0.7 g~nd LSSTCam SDSSg~ND_OD1.0 g~nd LSSTCam SDSSg~ND_OD2.0 g~nd LSSTCam SDSSg~ND_OD3.0 g~nd LSSTCam SDSSg~ND_OD4.0 g~nd LSSTCam SDSSi i LSSTCam SDSSi~ND_OD0.01 i~nd LSSTCam SDSSi~ND_OD0.05 i~nd LSSTCam SDSSi~ND_OD0.1 i~nd LSSTCam SDSSi~ND_OD0.3 i~nd LSSTCam SDSSi~ND_OD0.4 i~nd LSSTCam SDSSi~ND_OD0.5 i~nd LSSTCam SDSSi~ND_OD0.7 i~nd LSSTCam SDSSi~ND_OD1.0 i~nd LSSTCam SDSSi~ND_OD2.0 i~nd LSSTCam SDSSi~ND_OD3.0 i~nd LSSTCam SDSSi~ND_OD4.0 i~nd LSSTCam SDSSr r LSSTCam SDSSr~ND_OD0.01 r~nd LSSTCam SDSSr~ND_OD0.05 r~nd LSSTCam SDSSr~ND_OD0.1 r~nd LSSTCam SDSSr~ND_OD0.3 r~nd LSSTCam SDSSr~ND_OD0.4 r~nd LSSTCam SDSSr~ND_OD0.5 r~nd LSSTCam SDSSr~ND_OD0.7 r~nd LSSTCam SDSSr~ND_OD1.0 r~nd LSSTCam SDSSr~ND_OD2.0 r~nd LSSTCam SDSSr~ND_OD3.0 r~nd LSSTCam SDSSr~ND_OD4.0 r~nd LSSTCam SDSSu u LSSTCam SDSSu~ND_OD0.01 u~nd LSSTCam SDSSu~ND_OD0.05 u~nd LSSTCam SDSSu~ND_OD0.1 u~nd LSSTCam SDSSu~ND_OD0.3 u~nd LSSTCam SDSSu~ND_OD0.4 u~nd LSSTCam SDSSu~ND_OD0.5 u~nd LSSTCam SDSSu~ND_OD0.7 u~nd LSSTCam SDSSu~ND_OD1.0 u~nd LSSTCam SDSSu~ND_OD2.0 u~nd LSSTCam SDSSu~ND_OD3.0 u~nd LSSTCam SDSSu~ND_OD4.0 u~nd LSSTCam SDSSz z LSSTCam SDSSz~ND_OD0.01 z~nd LSSTCam SDSSz~ND_OD0.05 z~nd LSSTCam SDSSz~ND_OD0.1 z~nd LSSTCam SDSSz~ND_OD0.3 z~nd LSSTCam SDSSz~ND_OD0.4 z~nd LSSTCam SDSSz~ND_OD0.5 z~nd LSSTCam SDSSz~ND_OD0.7 z~nd LSSTCam SDSSz~ND_OD1.0 z~nd LSSTCam SDSSz~ND_OD2.0 z~nd LSSTCam SDSSz~ND_OD3.0 z~nd LSSTCam SDSSz~ND_OD4.0 z~nd LSSTCam empty white LSSTCam g g LSSTCam grid grid LSSTCam grid~ND_OD0.01 grid~nd LSSTCam grid~ND_OD0.05 grid~nd LSSTCam grid~ND_OD0.1 grid~nd LSSTCam grid~ND_OD0.3 grid~nd LSSTCam grid~ND_OD0.4 grid~nd LSSTCam grid~ND_OD0.5 grid~nd LSSTCam grid~ND_OD0.7 grid~nd LSSTCam grid~ND_OD1.0 grid~nd LSSTCam grid~ND_OD2.0 grid~nd LSSTCam grid~ND_OD3.0 grid~nd LSSTCam grid~ND_OD4.0 grid~nd LSSTCam i i LSSTCam r r LSSTCam spot spot LSSTCam spot~ND_OD0.01 spot~nd LSSTCam spot~ND_OD0.05 spot~nd LSSTCam spot~ND_OD0.1 spot~nd LSSTCam spot~ND_OD0.3 spot~nd LSSTCam spot~ND_OD0.4 spot~nd LSSTCam spot~ND_OD0.5 spot~nd LSSTCam spot~ND_OD0.7 spot~nd LSSTCam spot~ND_OD1.0 spot~nd LSSTCam spot~ND_OD2.0 spot~nd LSSTCam spot~ND_OD3.0 spot~nd LSSTCam spot~ND_OD4.0 spot~nd LSSTCam u u LSSTCam unknown unknown LSSTCam y y LSSTCam z z I fixed the blank->white issue as well. This change required that I make a small change to obs_base to make it handle afwFilter duplication a bit better. That is for deprecated code so I hope it's not contentious.
            Hide
            tjenness Tim Jenness added a comment -

            Patrick Ingraham thanks. I've change LATISS to not attach a grating to diffuser. The list is now:

            instrument              name               band  
            ---------- ----------------------------- --------
                LATISS                          BG40        g
                LATISS                    BG40~empty        g
                LATISS            BG40~ronchi170lpmm        g
                LATISS             BG40~ronchi90lpmm        g
                LATISS                  BG40~unknown        g
                LATISS               KPNO_1111_436nm        g
                LATISS         KPNO_1111_436nm~empty        g
                LATISS KPNO_1111_436nm~ronchi170lpmm        g
                LATISS  KPNO_1111_436nm~ronchi90lpmm        g
                LATISS       KPNO_1111_436nm~unknown        g
                LATISS               KPNO_373A_677nm        r
                LATISS         KPNO_373A_677nm~empty        r
                LATISS KPNO_373A_677nm~ronchi170lpmm        r
                LATISS  KPNO_373A_677nm~ronchi90lpmm        r
                LATISS       KPNO_373A_677nm~unknown        r
                LATISS                KPNO_406_828nm        z
                LATISS          KPNO_406_828nm~empty        z
                LATISS  KPNO_406_828nm~ronchi170lpmm        z
                LATISS   KPNO_406_828nm~ronchi90lpmm        z
                LATISS        KPNO_406_828nm~unknown        z
                LATISS                         RG610        r
                LATISS                   RG610~empty        r
                LATISS           RG610~ronchi170lpmm        r
                LATISS            RG610~ronchi90lpmm        r
                LATISS                 RG610~unknown        r
                LATISS                blank_bk7_wg05    white
                LATISS          blank_bk7_wg05~empty    white
                LATISS  blank_bk7_wg05~ronchi170lpmm    white
                LATISS   blank_bk7_wg05~ronchi90lpmm    white
                LATISS        blank_bk7_wg05~unknown    white
                LATISS                      diffuser diffuser
                LATISS                         empty    white
                LATISS                   empty~empty    white
                LATISS           empty~ronchi170lpmm    white
                LATISS            empty~ronchi90lpmm    white
                LATISS                 empty~unknown    white
                LATISS                    quadnotch1    notch
                LATISS              quadnotch1~empty    notch
                LATISS      quadnotch1~ronchi170lpmm    notch
                LATISS       quadnotch1~ronchi90lpmm    notch
                LATISS            quadnotch1~unknown    notch
                LATISS                       unknown  unknown
                LATISS                 unknown~empty  unknown
                LATISS         unknown~ronchi170lpmm  unknown
                LATISS          unknown~ronchi90lpmm  unknown
                LATISS               unknown~unknown  unknown
            

            Show
            tjenness Tim Jenness added a comment - Patrick Ingraham thanks. I've change LATISS to not attach a grating to diffuser. The list is now: instrument name band ---------- ----------------------------- -------- LATISS BG40 g LATISS BG40~empty g LATISS BG40~ronchi170lpmm g LATISS BG40~ronchi90lpmm g LATISS BG40~unknown g LATISS KPNO_1111_436nm g LATISS KPNO_1111_436nm~empty g LATISS KPNO_1111_436nm~ronchi170lpmm g LATISS KPNO_1111_436nm~ronchi90lpmm g LATISS KPNO_1111_436nm~unknown g LATISS KPNO_373A_677nm r LATISS KPNO_373A_677nm~empty r LATISS KPNO_373A_677nm~ronchi170lpmm r LATISS KPNO_373A_677nm~ronchi90lpmm r LATISS KPNO_373A_677nm~unknown r LATISS KPNO_406_828nm z LATISS KPNO_406_828nm~empty z LATISS KPNO_406_828nm~ronchi170lpmm z LATISS KPNO_406_828nm~ronchi90lpmm z LATISS KPNO_406_828nm~unknown z LATISS RG610 r LATISS RG610~empty r LATISS RG610~ronchi170lpmm r LATISS RG610~ronchi90lpmm r LATISS RG610~unknown r LATISS blank_bk7_wg05 white LATISS blank_bk7_wg05~empty white LATISS blank_bk7_wg05~ronchi170lpmm white LATISS blank_bk7_wg05~ronchi90lpmm white LATISS blank_bk7_wg05~unknown white LATISS diffuser diffuser LATISS empty white LATISS empty~empty white LATISS empty~ronchi170lpmm white LATISS empty~ronchi90lpmm white LATISS empty~unknown white LATISS quadnotch1 notch LATISS quadnotch1~empty notch LATISS quadnotch1~ronchi170lpmm notch LATISS quadnotch1~ronchi90lpmm notch LATISS quadnotch1~unknown notch LATISS unknown unknown LATISS unknown~empty unknown LATISS unknown~ronchi170lpmm unknown LATISS unknown~ronchi90lpmm unknown LATISS unknown~unknown unknown
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            Those results all look great, I think - I'll get to the code review now.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Those results all look great, I think - I'll get to the code review now.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            All looks great.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - All looks great.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Merlin Fisher-Levine
              Watchers:
              Merlin Fisher-Levine, Patrick Ingraham, Robert Lupton, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.