Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28495

ATDomeTrajectory sending negative dome position commands

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      During the last run (see entry in log at 05:51am CLT) the ATDometrajectory CSC started sending negative positions to the ATDome CSC which only accepts a range of 0-360. Obviously the dome was in the wrong position but also no errors were thrown from either CSC which were apparent to the operator.

      https://confluence.lsstcorp.org/display/LSSTCOM/2021-01-21+Night+Log

      The issue was resolved by cycling both the Dome and ATDomeTrajectory CSCs. I can't remember off hand if we tried cycling just the ATDomeTrajectory or not...

        Attachments

          Issue Links

          is child task of

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. CAP-667 Catch-all for T&S tickets for ts_xml 8 (formerly 7.2)

          • Undefined - No priority assigned (may not apply or be unknown)
          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment -

            I proppose to fix this by allowing ATDome to accept azimuth outside the range 0-360 (and wrapping it to >= 0, < 360 for the low-level dome controller). It may be worth updating ATDomeTrajectory as well, but I consider that optional.

            Show
            rowen Russell Owen added a comment - I proppose to fix this by allowing ATDome to accept azimuth outside the range 0-360 (and wrapping it to >= 0, < 360 for the low-level dome controller). It may be worth updating ATDomeTrajectory as well, but I consider that optional.
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            I decided there was no point to updating ATDomeTrajectory. Making ATDome more generous in what azimuth angles it accepts is enough.

            In ts_xml I updated the description of the ATDome moveAzimuth command.
            In ts_ATDome I updated the code (a trivial change) and the unit test of moveAzimuth (a bigger change).

            Pull requests:

            Show
            rowen Russell Owen added a comment - - edited I decided there was no point to updating ATDomeTrajectory. Making ATDome more generous in what azimuth angles it accepts is enough. In ts_xml I updated the description of the ATDome moveAzimuth command. In ts_ATDome I updated the code (a trivial change) and the unit test of moveAzimuth (a bigger change). Pull requests: https://github.com/lsst-ts/ts_ATDome/pull/36 https://github.com/lsst-ts/ts_xml/pull/404
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            LGTM

            Show
            wvreeven Wouter van Reeven added a comment - LGTM
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Released ts_ATDome v1.3.4

            Show
            rowen Russell Owen added a comment - Released ts_ATDome v1.3.4

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              pingraham Patrick Ingraham
              Reviewers:
              Wouter van Reeven
              Watchers:
              Patrick Ingraham, Russell Owen, Tiago Ribeiro, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Due:
                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.