Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28542

Implement RFC-750

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • pipe_tasks
    • None
    • 16
    • DRP S21a (Dec Jan)
    • Data Release Production
    • No

    Description

      Add the `isSimpleLeaf` and `isModelLeaf` flags to catalogs, and have `isPrimary` give the same value as `isSimpleLeaf`.

      Attachments

        Issue Links

          Activity

            Sorry this has been such a slog, but I've now marked everything as reviewed.  There are a few outstanding naming issues I'm struggling with which I have noted on the PR and the RFC.  If you could give the other watchers a chance to weigh in, that would be great.  As I've also noted, I'm willing to give in if I'm alone on an island on either issue!  I'll leave this up to your discretion and you can then feel free to merge after a final Jenkins + ci_hsc run.

            I also think it would be a good idea to run multiband and the pipe_analysis scripts on the RC2 tracts prior to the next official run so we can update the flag selections on the latter and make sure all looks as you would expect when we do so (we can do this post-merge, but I don't want any more surprises for Eric's next run that we could/should've avoided!).

            lauren Lauren MacArthur added a comment - Sorry this has been such a slog, but I've now marked everything as reviewed.  There are a few outstanding naming issues I'm struggling with which I have noted on the PR and the RFC.  If you could give the other watchers a chance to weigh in, that would be great.  As I've also noted, I'm willing to give in if I'm alone on an island on either issue!  I'll leave this up to your discretion and you can then feel free to merge after a final Jenkins + ci_hsc run. I also think it would be a good idea to run multiband  and the pipe_analysis scripts on the RC2 tracts prior to the next official run so we can update the flag selections on the latter and make sure all looks as you would expect when we do so (we can do this post-merge, but I don't want any more surprises for Eric's next run that we could/should've avoided!).

            Thanks lauren. I updated the RFC with new column names `isDeblendedSource` and `isDeblendedModelSource` which will hopefully settle that issue (but chime in if that's not the case). I'll rebase with these last updates and run the 9813 RC2 tract (since that's the one that's most likely to give us any issues), Jenkins, and ci_hsc. That should give people at least a day to update RFC-750 if they see fit, and then I can merge this ticket and you/I can create a ticket that implements the new flags in pipe_analysis so that we can test it before the next full RC2 re-processing.

            fred3m Fred Moolekamp added a comment - Thanks lauren . I updated the RFC with new column names `isDeblendedSource` and `isDeblendedModelSource` which will hopefully settle that issue (but chime in if that's not the case). I'll rebase with these last updates and run the 9813 RC2 tract (since that's the one that's most likely to give us any issues), Jenkins, and ci_hsc. That should give people at least a day to update RFC-750 if they see fit, and then I can merge this ticket and you/I can create a ticket that implements the new flags in pipe_analysis so that we can test it before the next full RC2 re-processing.

            Thanks, Fred.  Sounds good to me!

            lauren Lauren MacArthur added a comment - Thanks, Fred.  Sounds good to me!
            fred3m Fred Moolekamp added a comment - - edited Successful Jenkins build (including ci_hsc): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33789/pipeline

            RC2 tract 9813 completed successfully and merged branches. lauren feel free to create a ticket to update pipe_analysis to use the new flags set in pipe_tasks and test on the rerun located at `/project/fred3m/rerun/rfc750`.

            fred3m Fred Moolekamp added a comment - RC2 tract 9813 completed successfully and merged branches. lauren feel free to create a ticket to update pipe_analysis to use the new flags set in pipe_tasks and test on the rerun located at `/project/fred3m/rerun/rfc750`.

            People

              fred3m Fred Moolekamp
              fred3m Fred Moolekamp
              Lauren MacArthur
              Fred Moolekamp, Lauren MacArthur
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.