Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28553

Update the gain, readNoise, and saturation levels based on EOTest

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      James Chiang has provided some updated gain, readNoise, and saturation levels based on analysis of BOT data. As some of the current gains are suspect (19??!?) we should update them before the next run of phosim for the active optics (AOS) group.

        Attachments

          Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. DM-27836 Correct amplifier gain values in LsstCamMapper

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            rhl Robert Lupton created issue -
            rhl Robert Lupton made changes -
            Field Original Value New Value
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            I've updated the values from some EOTest analysis,

            Show
            rhl Robert Lupton added a comment - I've updated the values from some EOTest analysis, https://github.com/lsst-camera-dh/EO-analysis-jobs/blob/a63d2499a8fed0574e3979bb14ee0d777a345cb0/data/curated_amp_gains_2020-09-16.json read_noise_12794.json ptc_turnoff_12794.json The read_noise and ptc_turnoff (i.e. saturation) come from run 12794 and can be found in eTraveller.
            rhl Robert Lupton made changes -
            Reviewers Bo Xin, James Chiang [ bxin, jchiang ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            jchiang James Chiang added a comment -

            For the record, the Jira issue (in Camera space) documenting the provenance of those curated gains is

            https://jira.slac.stanford.edu/browse/LSSTTD-1510

            For the read noise and ptc turnoff values, the standard set of EO test plots for Run 12794 can be found at

            https://srs.slac.stanford.edu/BOT_EO_Reports/12794/

             

            Show
            jchiang James Chiang added a comment - For the record, the Jira issue (in Camera space) documenting the provenance of those curated gains is https://jira.slac.stanford.edu/browse/LSSTTD-1510 For the read noise and ptc turnoff values, the standard set of EO test plots for Run 12794 can be found at https://srs.slac.stanford.edu/BOT_EO_Reports/12794/  
            tjenness Tim Jenness made changes -
            Assignee Robert Lupton [ rhl ]
            tjenness Tim Jenness made changes -
            Team Data Release Production [ 10301 ]
            Hide
            Permalink
            bxin Bo Xin [X] (Inactive) added a comment - - edited

            This update is only for R32_S11, is that right?

            Show
            bxin Bo Xin [X] (Inactive) added a comment - - edited This update is only for R32_S11, is that right?
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            No, if we're going to update any numbers it seemed better to update them all. After all, we know that the values we had were not reliable.

            Show
            rhl Robert Lupton added a comment - No, if we're going to update any numbers it seemed better to update them all. After all, we know that the values we had were not reliable.
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Sorry, I didn't create a GitHub PR. Done now; https://github.com/lsst/obs_lsst/pull/284

            Show
            rhl Robert Lupton added a comment - Sorry, I didn't create a GitHub PR. Done now; https://github.com/lsst/obs_lsst/pull/284
            rhl Robert Lupton made changes -
            Status In Review [ 10004 ] In Progress [ 3 ]
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Resolved KT's bug report on previous PR. New PR is at
            https://github.com/lsst/obs_lsst/pull/286

            Show
            rhl Robert Lupton added a comment - Resolved KT's bug report on previous PR. New PR is at https://github.com/lsst/obs_lsst/pull/286
            rhl Robert Lupton made changes -
            Reviewers Bo Xin, James Chiang [ bxin, jchiang ] Bo Xin, James Chiang, Kian-Tat Lim [ bxin, jchiang, ktl ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            One comment on a comment; several values are unusual but are likely correct.

            Show
            ktl Kian-Tat Lim added a comment - One comment on a comment; several values are unusual but are likely correct.
            ktl Kian-Tat Lim made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            ksuberlak Krzysztof Suberlak added a comment -

            Are there any obstacles for that to be merged to master ? The "0.0" gain on master for R10_S00 C00 causes some issues when making calibs.

            Show
            ksuberlak Krzysztof Suberlak added a comment - Are there any obstacles for that to be merged to master ? The "0.0" gain on master for R10_S00 C00 causes some issues when making calibs.
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            I think Bo's comment on the PR is still unresolved, but I don't know if this is a case of "something is better than nothing".

            Show
            ktl Kian-Tat Lim added a comment - I think Bo's comment on the PR is still unresolved, but I don't know if this is a case of "something is better than nothing".
            Hide
            Permalink
            jchiang James Chiang added a comment -

            I'll try to follow up on Bo's comment (just saw it now.)

            Show
            jchiang James Chiang added a comment - I'll try to follow up on Bo's comment (just saw it now.)
            Hide
            Permalink
            ksuberlak Krzysztof Suberlak added a comment -

            There's a suggestion from Craig Lage to further update lsstCam gain/readNoise. That would be a follow-up ticket.

            Show
            ksuberlak Krzysztof Suberlak added a comment - There's a suggestion from Craig Lage to further update lsstCam gain/readNoise. That would be a follow-up ticket.
            Hide
            Permalink
            ksuberlak Krzysztof Suberlak added a comment -

            ( related to comCam update https://github.com/lsst/obs_lsst/pull/292 )

            Show
            ksuberlak Krzysztof Suberlak added a comment - ( related to comCam update https://github.com/lsst/obs_lsst/pull/292 )
            rhl Robert Lupton made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Confirmed with Bo. Rebased, merged, and pushed.

            Show
            rhl Robert Lupton added a comment - Confirmed with Bo. Rebased, merged, and pushed.
            ksuberlak Krzysztof Suberlak made changes -
            Link This issue duplicates DM-27836 [ DM-27836 ]

              People

              Assignee:
              rhl Robert Lupton
              Reporter:
              rhl Robert Lupton
              Reviewers:
              Bo Xin [X] (Inactive), James Chiang, Kian-Tat Lim
              Watchers:
              Bo Xin [X] (Inactive), James Chiang, Kian-Tat Lim, Krzysztof Suberlak, Robert Lupton
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.