Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28557

Update phosim_syseng4 segmentation.txt gain and read noise

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_aos
    • Labels:

      Description

      Update the data/lsst segmentation.txt  gain and read noise values and focalplanelayout.txt geometry (x,y position, overscan,prescan), sensor names, to make them consistent with those in obs_lsst for lsst.obs.lsst.LsstCam ( eg. https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml ). 

      Currently, the values in data/lsst are consistent with PhosimMapper, but DM-28556 creates a need to move to LsstCamMapper. To allow ISR, the calibration files (made with makeGainImages.py https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py for images simulated for `LsstCam` instrument also need to use geometry and gain values consistent with LsstCam. 

        Attachments

          Issue Links

          has to be done before

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28341 ingest phosim images into Butler with as-built camera geometry

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28556 Adapt the Latest File Format of Corner WFS

          • Done
          is parent task of

          Improvement - An improvement or enhancement to an existing feature or task. DM-29233 Update ts_phosim tests

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-29264 Update phosim_syseng4 for ComCam

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-29232 Update ts_phosim tests

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            ksuberlak Krzysztof Suberlak created issue -
            ksuberlak Krzysztof Suberlak made changes -
            Field Original Value New Value
            Link This issue has to be done before DM-28341 [ DM-28341 ]
            ksuberlak Krzysztof Suberlak made changes -
            Link This issue clones TAS-97 [ TAS-97 ]
            ksuberlak Krzysztof Suberlak made changes -
            Link This issue duplicates TAS-97 [ TAS-97 ]
            ksuberlak Krzysztof Suberlak made changes -
            Link This issue is cloned by DM-28549 [ DM-28549 ]
            ksuberlak Krzysztof Suberlak made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            ksuberlak Krzysztof Suberlak made changes -
            Description Update the segmentation.txt  [https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values to make them consistent with those in {{lsstCamMapper}} ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{segmentation.txt}} are consistent with {{PhosimMapper}}, but DM-26836 creates a need to move to {{LsstCamMapper}}. Thus the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] need to use geometry and gain values consistent with LsstCam.              		Update the segmentation.txt  [https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values to make them consistent with those in {{lsstCamMapper}} ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{segmentation.txt}} are consistent with {{PhosimMapper}}, but DM-28556 creates a need to move to {{LsstCamMapper}}. Thus the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] need to use geometry and gain values consistent with LsstCam. 
            ksuberlak Krzysztof Suberlak made changes -
            Link This issue has to be done before DM-28556 [ DM-28556 ]
            ksuberlak Krzysztof Suberlak made changes -
            Link This issue is cloned by DM-28549 [ DM-28549 ]
            ksuberlak Krzysztof Suberlak made changes -
            Link This issue clones TAS-97 [ TAS-97 ]
            ksuberlak Krzysztof Suberlak made changes -
            Description Update the segmentation.txt  [https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values to make them consistent with those in {{lsstCamMapper}} ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{segmentation.txt}} are consistent with {{PhosimMapper}}, but DM-28556 creates a need to move to {{LsstCamMapper}}. Thus the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] need to use geometry and gain values consistent with LsstCam.              		Update the {{data/lsst}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values to make them consistent with those in {{obs_lsst}} for `lsst.obs.lsst.LsstCam` ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{segmentation.txt}} are consistent with {{PhosimMapper}}, but DM-28556 creates a need to move to {{LsstCamMapper}}. Thus the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] need to use geometry and gain values consistent with LsstCam. 

             

            Also, update the [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/segmentation.txt] and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/focalplanelayout.txt] for ComCam to make them consistent with values of read noise, gain, geometry (x,y position, overscan/prescan) within obs_lsst, (assuming the updated comCam read noise / gain values from DM-28919 ). This change also necessitates :
             * updating phosim_utils {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] to make it possible to use read noise / gain from [https://github.com/lsst/obs_lsst/blob/master/policy/comCam/R22.yaml], i.e. {{from lsst.obs.lsst import LsstComCam}}
             * updating ts_phosim {{CloseLoopTask.py}} call to {{makeGainImages.py}} to allow choice of instrument (either `lsstfam` to create calibs with read noise/ gain / geometry from `lsst.obs.lsst.LsstCam` , or `comcam` to use `lsst.obs.lsst.LsstComCam` ([https://github.com/lsst-ts/ts_phosim/blob/master/python/lsst/ts/phosim/CloseLoopTask.py#L937] )
            ksuberlak Krzysztof Suberlak made changes -
            Description Update the {{data/lsst}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values to make them consistent with those in {{obs_lsst}} for `lsst.obs.lsst.LsstCam` ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{segmentation.txt}} are consistent with {{PhosimMapper}}, but DM-28556 creates a need to move to {{LsstCamMapper}}. Thus the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] need to use geometry and gain values consistent with LsstCam. 

             

            Also, update the [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/segmentation.txt] and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/focalplanelayout.txt] for ComCam to make them consistent with values of read noise, gain, geometry (x,y position, overscan/prescan) within obs_lsst, (assuming the updated comCam read noise / gain values from DM-28919 ). This change also necessitates :
             * updating phosim_utils {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] to make it possible to use read noise / gain from [https://github.com/lsst/obs_lsst/blob/master/policy/comCam/R22.yaml], i.e. {{from lsst.obs.lsst import LsstComCam}}
             * updating ts_phosim {{CloseLoopTask.py}} call to {{makeGainImages.py}} to allow choice of instrument (either `lsstfam` to create calibs with read noise/ gain / geometry from `lsst.obs.lsst.LsstCam` , or `comcam` to use `lsst.obs.lsst.LsstComCam` ([https://github.com/lsst-ts/ts_phosim/blob/master/python/lsst/ts/phosim/CloseLoopTask.py#L937] )             		Update the {{data/lsst}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values to make them consistent with those in {{obs_lsst}} for {{lsst.obs.lsst.LsstCam}} ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{segmentation.txt}} are consistent with {{PhosimMapper}}, but DM-28556 creates a need to move to {{LsstCamMapper}}. Thus the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] need to use geometry and gain values consistent with LsstCam. 

             

            Also, update the [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/segmentation.txt] and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/focalplanelayout.txt] for ComCam to make them consistent with values of read noise, gain, geometry (x,y position, overscan/prescan) within obs_lsst, (assuming the updated comCam read noise / gain values from DM-28919 ). This change also necessitates :
             * updating phosim_utils {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] to make it possible to use read noise / gain from [https://github.com/lsst/obs_lsst/blob/master/policy/comCam/R22.yaml], i.e. {{from lsst.obs.lsst import LsstComCam}}
             * updating ts_phosim {{CloseLoopTask.py}} call to {{makeGainImages.py}} to allow choice of instrument (either {{lsstfam}} to create calibs with read noise/ gain / geometry from {{lsst.obs.lsst.LsstCam}} , or {{comcam}} to use {{lsst.obs.lsst.LsstComCam}} ([https://github.com/lsst-ts/ts_phosim/blob/master/python/lsst/ts/phosim/CloseLoopTask.py#L937] )
            ksuberlak Krzysztof Suberlak made changes -
            Description Update the {{data/lsst}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values to make them consistent with those in {{obs_lsst}} for {{lsst.obs.lsst.LsstCam}} ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{segmentation.txt}} are consistent with {{PhosimMapper}}, but DM-28556 creates a need to move to {{LsstCamMapper}}. Thus the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] need to use geometry and gain values consistent with LsstCam. 

             

            Also, update the [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/segmentation.txt] and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/focalplanelayout.txt] for ComCam to make them consistent with values of read noise, gain, geometry (x,y position, overscan/prescan) within obs_lsst, (assuming the updated comCam read noise / gain values from DM-28919 ). This change also necessitates :
             * updating phosim_utils {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] to make it possible to use read noise / gain from [https://github.com/lsst/obs_lsst/blob/master/policy/comCam/R22.yaml], i.e. {{from lsst.obs.lsst import LsstComCam}}
             * updating ts_phosim {{CloseLoopTask.py}} call to {{makeGainImages.py}} to allow choice of instrument (either {{lsstfam}} to create calibs with read noise/ gain / geometry from {{lsst.obs.lsst.LsstCam}} , or {{comcam}} to use {{lsst.obs.lsst.LsstComCam}} ([https://github.com/lsst-ts/ts_phosim/blob/master/python/lsst/ts/phosim/CloseLoopTask.py#L937] )             		Update the {{data/lsst}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values to make them consistent with those in {{obs_lsst}} for {{lsst.obs.lsst.LsstCam}} ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{segmentation.txt}} are consistent with {{PhosimMapper}}, but DM-28556 creates a need to move to {{LsstCamMapper}}. Thus the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] need to use geometry and gain values consistent with LsstCam. 

             

            Also, update the {{data/comcam}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/segmentation.txt] and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/focalplanelayout.txt] for ComCam to make them consistent with values of read noise, gain, geometry (x,y position, overscan/prescan) within obs_lsst, (assuming the updated comCam read noise / gain values from DM-28919 ). This change also necessitates :
             * updating phosim_utils {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] to make it possible to use read noise / gain from [https://github.com/lsst/obs_lsst/blob/master/policy/comCam/R22.yaml], i.e. {{from lsst.obs.lsst import LsstComCam}}
             * updating ts_phosim {{CloseLoopTask.py}} call to {{makeGainImages.py}} to allow choice of instrument (either {{lsstfam}} to create calibs with read noise/ gain / geometry from {{lsst.obs.lsst.LsstCam}} , or {{comcam}} to use {{lsst.obs.lsst.LsstComCam}} ([https://github.com/lsst-ts/ts_phosim/blob/master/python/lsst/ts/phosim/CloseLoopTask.py#L937] )
            ksuberlak Krzysztof Suberlak made changes -
            Description Update the {{data/lsst}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values to make them consistent with those in {{obs_lsst}} for {{lsst.obs.lsst.LsstCam}} ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{segmentation.txt}} are consistent with {{PhosimMapper}}, but DM-28556 creates a need to move to {{LsstCamMapper}}. Thus the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] need to use geometry and gain values consistent with LsstCam. 

             

            Also, update the {{data/comcam}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/segmentation.txt] and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/focalplanelayout.txt] for ComCam to make them consistent with values of read noise, gain, geometry (x,y position, overscan/prescan) within obs_lsst, (assuming the updated comCam read noise / gain values from DM-28919 ). This change also necessitates :
             * updating phosim_utils {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] to make it possible to use read noise / gain from [https://github.com/lsst/obs_lsst/blob/master/policy/comCam/R22.yaml], i.e. {{from lsst.obs.lsst import LsstComCam}}
             * updating ts_phosim {{CloseLoopTask.py}} call to {{makeGainImages.py}} to allow choice of instrument (either {{lsstfam}} to create calibs with read noise/ gain / geometry from {{lsst.obs.lsst.LsstCam}} , or {{comcam}} to use {{lsst.obs.lsst.LsstComCam}} ([https://github.com/lsst-ts/ts_phosim/blob/master/python/lsst/ts/phosim/CloseLoopTask.py#L937] )             		Update the {{data/lsst}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/focalplanelayout.txt] geometry (x,y position, overscan,prescan), sensor names, to make them consistent with those in {{obs_lsst}} for {{lsst.obs.lsst.LsstCam}} ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{segmentation.txt}} are consistent with {{PhosimMapper}}, but DM-28556 creates a need to move to {{LsstCamMapper}}. Thus the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] need to use geometry and gain values consistent with LsstCam. 

             

            Also, update the {{data/comcam}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/segmentation.txt] and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/focalplanelayout.txt] for ComCam to make them consistent with values of read noise, gain, geometry (x,y position, overscan/prescan) within obs_lsst, (assuming the updated comCam read noise / gain values from DM-28919 ). This change also necessitates :
             * updating phosim_utils {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] to make it possible to use read noise / gain from [https://github.com/lsst/obs_lsst/blob/master/policy/comCam/R22.yaml], i.e. {{from lsst.obs.lsst import LsstComCam}}
             * updating ts_phosim {{CloseLoopTask.py}} call to {{makeGainImages.py}} to allow choice of instrument (either {{lsstfam}} to create calibs with read noise/ gain / geometry from {{lsst.obs.lsst.LsstCam}} , or {{comcam}} to use {{lsst.obs.lsst.LsstComCam}} ([https://github.com/lsst-ts/ts_phosim/blob/master/python/lsst/ts/phosim/CloseLoopTask.py#L937] )
            ksuberlak Krzysztof Suberlak made changes -
            Description Update the {{data/lsst}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/focalplanelayout.txt] geometry (x,y position, overscan,prescan), sensor names, to make them consistent with those in {{obs_lsst}} for {{lsst.obs.lsst.LsstCam}} ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{segmentation.txt}} are consistent with {{PhosimMapper}}, but DM-28556 creates a need to move to {{LsstCamMapper}}. Thus the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] need to use geometry and gain values consistent with LsstCam. 

             

            Also, update the {{data/comcam}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/segmentation.txt] and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/focalplanelayout.txt] for ComCam to make them consistent with values of read noise, gain, geometry (x,y position, overscan/prescan) within obs_lsst, (assuming the updated comCam read noise / gain values from DM-28919 ). This change also necessitates :
             * updating phosim_utils {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] to make it possible to use read noise / gain from [https://github.com/lsst/obs_lsst/blob/master/policy/comCam/R22.yaml], i.e. {{from lsst.obs.lsst import LsstComCam}}
             * updating ts_phosim {{CloseLoopTask.py}} call to {{makeGainImages.py}} to allow choice of instrument (either {{lsstfam}} to create calibs with read noise/ gain / geometry from {{lsst.obs.lsst.LsstCam}} , or {{comcam}} to use {{lsst.obs.lsst.LsstComCam}} ([https://github.com/lsst-ts/ts_phosim/blob/master/python/lsst/ts/phosim/CloseLoopTask.py#L937] )             		Update the {{data/lsst}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/focalplanelayout.txt] geometry (x,y position, overscan,prescan), sensor names, to make them consistent with those in {{obs_lsst}} for {{lsst.obs.lsst.LsstCam}} ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{data/lsst}} are consistent with {{PhosimMapper}}, but DM-28556 creates a need to move to {{LsstCamMapper}}. To allow ISR, the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] for images simulated for `LsstCam` instrument also need to use geometry and gain values consistent with LsstCam. 

             
            Also, update the {{data/comcam}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/segmentation.txt] and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/focalplanelayout.txt] for ComCam to make them consistent with values of read noise, gain, geometry (x,y position, overscan/prescan) within obs_lsst, (assuming the updated comCam read noise / gain values from DM-28919 ). This change also necessitates :
             * updating phosim_utils {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] to make it possible to use read noise / gain from [https://github.com/lsst/obs_lsst/blob/master/policy/comCam/R22.yaml], i.e. {{from lsst.obs.lsst import LsstComCam}}
             * updating ts_phosim {{CloseLoopTask.py}} call to {{makeGainImages.py}} to allow choice of instrument (either {{lsstfam}} to create calibs with read noise/ gain / geometry from {{lsst.obs.lsst.LsstCam}} , or {{comcam}} to use {{lsst.obs.lsst.LsstComCam}} ([https://github.com/lsst-ts/ts_phosim/blob/master/python/lsst/ts/phosim/CloseLoopTask.py#L937] )
            ksuberlak Krzysztof Suberlak made changes -
            Description Update the {{data/lsst}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/focalplanelayout.txt] geometry (x,y position, overscan,prescan), sensor names, to make them consistent with those in {{obs_lsst}} for {{lsst.obs.lsst.LsstCam}} ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{data/lsst}} are consistent with {{PhosimMapper}}, but DM-28556 creates a need to move to {{LsstCamMapper}}. To allow ISR, the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] for images simulated for `LsstCam` instrument also need to use geometry and gain values consistent with LsstCam. 

             
            Also, update the {{data/comcam}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/segmentation.txt] and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/focalplanelayout.txt] for ComCam to make them consistent with values of read noise, gain, geometry (x,y position, overscan/prescan) within obs_lsst, (assuming the updated comCam read noise / gain values from DM-28919 ). This change also necessitates :
             * updating phosim_utils {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] to make it possible to use read noise / gain from [https://github.com/lsst/obs_lsst/blob/master/policy/comCam/R22.yaml], i.e. {{from lsst.obs.lsst import LsstComCam}}
             * updating ts_phosim {{CloseLoopTask.py}} call to {{makeGainImages.py}} to allow choice of instrument (either {{lsstfam}} to create calibs with read noise/ gain / geometry from {{lsst.obs.lsst.LsstCam}} , or {{comcam}} to use {{lsst.obs.lsst.LsstComCam}} ([https://github.com/lsst-ts/ts_phosim/blob/master/python/lsst/ts/phosim/CloseLoopTask.py#L937] )             		Update the {{data/lsst}} [segmentation.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/segmentation.txt]  *gain* and *read* *noise* values and [focalplanelayout.txt|https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/lsst/focalplanelayout.txt] geometry (x,y position, overscan,prescan), sensor names, to make them consistent with those in {{obs_lsst}} for {{lsst.obs.lsst.LsstCam}} ( eg. [https://github.com/lsst/obs_lsst/blob/master/policy/lsstCam/R00.yaml] ). 

            Currently, the values in {{data/lsst}} are consistent with {{PhosimMapper}}, but DM-28556 creates a need to move to {{LsstCamMapper}}. To allow ISR, the calibration files (made with {{makeGainImages.py}} [https://github.com/lsst-dm/phosim_utils/blob/master/bin.src/makeGainImages.py] for images simulated for `LsstCam` instrument also need to use geometry and gain values consistent with LsstCam. 
            ksuberlak Krzysztof Suberlak made changes -
            Status In Progress [ 3 ] In Review [ 10004 ]
            ttsai Te-Wei Tsai made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            ksuberlak Krzysztof Suberlak made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            ksuberlak Krzysztof Suberlak made changes -
            Link This issue is parent task of DM-29232 [ DM-29232 ]
            ksuberlak Krzysztof Suberlak made changes -
            Link This issue is parent task of DM-29233 [ DM-29233 ]
            ksuberlak Krzysztof Suberlak made changes -
            Link This issue is parent task of DM-29264 [ DM-29264 ]

              People

              Assignee:
              ksuberlak Krzysztof Suberlak
              Reporter:
              ksuberlak Krzysztof Suberlak
              Reviewers:
              Te-Wei Tsai
              Watchers:
              Krzysztof Suberlak, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.