Also updating the name of corner and guide sensors to match lsstCamMapper. The main raft  in phosim  has the same sensor names   as in lsstCam. The corner and guide sensors need change, e.g.: 

R04_S20_C0 --> R04_SW1 (intra-focal)
R04_S20_C1 --> R04_SW0 (extra-focal) 
R04_S21 --> R04_SG1
R04_S10 --> R04_SG0

R44_S00_C0 --> R44_SW1 
R44_S00_C1 --> R44_SW0
R44_S01 --> R44_SG0
R44_S10 --> R44_SG1

R00_S22_C0 --> R00_SW1
R00_S22_C1 --> R00_SW0
R00_S12 --> R00_SG0
R00_S21 --> R00_SG1

R40_S02_C0 --> R40_SW1 
R40_S02_C1  --> R40_SW0 
R40_S12 --> R40_SG1
R40_S01 --> R40_SG0

Progress of work in the notebook /home/scichris/notebooks/AOS_segmentation.ipynb on LSP.

Verified that updating sensor and amp names, bias and read noise values produces  a result in `phosim_syseng4` version of phosim, simulating stars on corner sensors. Results in `/project/scichris/aos/segmentation_update/corner_sensors/after/`. Adding geometry changes to segmentation.txt and focalplanelayout.txt.

Made updates to the geometry (position in the focal plane) for focalplanelayout.txt. Updated makeGainImages.py to use lsstCam values for gain and geometry. Verified that the ISR works with corner sensors. Results for one corner sensor in /project/scichris/aos/segmentation_update/corner_sensors/arrowsLetters/input2/ . Testing for comcam with images of arrows in /project/scichris/aos/segmentation_update/comcam/arrows/ .

What was called comcam above is actually R22 of lsstCam (E2V chip). The ISR works properly. Integrated into the AOS loop with DM-28556 (changes to phosim_utils) and DM-28330, (changes to ts_wep). Testing the convergence of the loop with new segmentation / focalplanelayout values for R22.

Now need DM-28553 to be closed (updated lsstCam gain/readNoise values) so that we avoid the 0 gain (which causes issues when making fake flats consisting of 1/gain per amplifier).

Adding the updated focalplanelayout.txt to ts_wep as part of DM-28330

This update looks good to me!

Summary of changes to data/lsst , as in https://github.com/lsst-ts/phosim_syseng4/pull/6 : 

Updating `data/lsst` `segmentation.txt` and `focalplanelayout.txt` with geometry and CCD properties appropriate for lsstCam from obs_lsst . Now a lsstCam focal plane contains a mix of ITL and E2V chips, using most up-to-date gain / read noise values from DM-28553 (https://github.com/lsst/obs_lsst/tree/tickets/DM-28553/policy/lsstCam ) .

*Summary of changes for `focalplanelayout.txt`*

• Column 0 : the mapping of names of corner and guide sensors is as follows (only few for example):

• Columns 1,2 : x,y -position [microns] updated using `detector.getBBox()`, `bbox.centerY`, `bbox.centerX` (phosim is rotated 90 degrees from lsstCam)
• Columns 4,5: number of x,y pixels updated with `xpx = bbox.getHeight()`, `ypx=bbox.getWidth()`
• Columns 15,16: x,y shift set to 0,0 since correct positions are provided with Columns 1,2 (most substantially this is noticeable for the corner sensors)
• Column 19: updated defocalShift from +/- 1000 to +/- 1500 micrometers

*Summary of changes for `segmentation.txt`:*

• short lines: update raft name, number of x,y pixels as above
• long lines:
• Columns 1,2,3,4: [xlo, xhi ,ylo, yhi] in px per amplifier ; for ITL these are unchanged, for E2V we have eg. instead `[0 1999 0 508]` --> `[0 2001 0 511]`
• Columns 5,6 serial read / parallel read : for ITL serial read is always 1, and parallel read is 1 or -1 ; for E2V, serial read is -1 when parallel read is -1 (Robert Lupton, priv.comm.)
• Column 7 : gain value
• Column 11 : read noise
• Column 15,16,17,17: prescan / overscan values, preserving phosim's rotation of 90 degrees to the left wrt lsstCam . This means that the following was adopted (and tested):

This translates to