Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28577

Surpress Filter warnings in FilterDefinitions

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base
    • Labels:
      None

      Description

      While running ci_hsc, I noticed that DM-27170 produces a lot of warnings due to the FilterDefinition calling reset() and defineFilter(). That class already knows that Filter is deprecated, so the warnings there are really just noise. It's easy enough to surpress the warnings with warnings.simplefilter, and I think that would be useful for helping users to find the places that are still using the deprecated interface.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27170 Deprecate and phase out afw::image::Filter

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28693 Additional Filter deprecation warnings in lsstCamMapper

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Link This issue is triggered by DM-27170 [ DM-27170 ]
            Parejkoj John Parejko made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            Tim Jenness: do you mind doing this short review of obs_base and obs_subaru? Please include any thoughts on whether this a good idea and whether there is anywhere else we should apply similar "warning supression" of deprecated interfaces that we know we still have to use for a while longer?

            Show
            Parejkoj John Parejko added a comment - - edited Tim Jenness : do you mind doing this short review of obs_base and obs_subaru? Please include any thoughts on whether this a good idea and whether there is anywhere else we should apply similar "warning supression" of deprecated interfaces that we know we still have to use for a while longer?
            Parejkoj John Parejko made changes -
            Reviewers Tim Jenness [ tjenness ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks good.

            Show
            tjenness Tim Jenness added a comment - Looks good.
            tjenness Tim Jenness made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33464/pipeline

            Show
            Parejkoj John Parejko added a comment - Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33464/pipeline
            Parejkoj John Parejko made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-28693 [ DM-28693 ]

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Tim Jenness
              Watchers:
              John Parejko, Krzysztof Findeisen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.