Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28583

Update fitsExposure formatter to fill in filterLabel from dataId

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Epic Link:
    • Sprint:
      DRP S21a (Dec Jan)
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      Currently reading an old calexp with gen3 gives an incomplete filterLabel. We have both band and physical_filter information from the dataId so this can be filled out properly, and a warning raised if there are any conflicts.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            I've updated the obs_base branch (and the tests in ci_hsc_gen3) to always use the filters from the data IDs when they are present. I suspect this is not enough to unblock Ian Sullivan, because I don't think the data IDs in the PipelineTasks are getting the information they need yet, but it may be worth a try.

            Show
            jbosch Jim Bosch added a comment - I've updated the obs_base branch (and the tests in ci_hsc_gen3) to always use the filters from the data IDs when they are present. I suspect this is not enough to unblock Ian Sullivan , because I don't think the data IDs in the PipelineTasks are getting the information they need yet, but it may be worth a try.
            Hide
            sullivan Ian Sullivan added a comment -

            Thanks Jim Bosch! I'll test it. We have decided to simply reprocess the data from raws instead of calexps, so as long as we get through that we won't actually be blocked on this. But, since other people may wish to use the data it is still good to get this fixed.

            Show
            sullivan Ian Sullivan added a comment - Thanks Jim Bosch ! I'll test it. We have decided to simply reprocess the data from raws instead of calexps, so as long as we get through that we won't actually be blocked on this. But, since other people may wish to use the data it is still good to get this fixed.
            Hide
            sullivan Ian Sullivan added a comment -

            I can confirm that that change to obs_base works. It throws a number of warnings, which seems reasonable, but then it proceeds to make warps. Thank you for the quick fix!

            Show
            sullivan Ian Sullivan added a comment - I can confirm that that change to obs_base works. It throws a number of warnings, which seems reasonable, but then it proceeds to make warps. Thank you for the quick fix!
            Hide
            jbosch Jim Bosch added a comment -

            Thanks, Ian Sullivan. That's not what I was expecting, but I realize now that it was my expectations that were wrong, because I misread your last error report. Everything is now consistent with there being no problem with the data IDs being passed to PipelineTask, and hence this is ready to go back into review.

            Show
            jbosch Jim Bosch added a comment - Thanks, Ian Sullivan . That's not what I was expecting, but I realize now that it was my expectations that were wrong, because I misread your last error report. Everything is now consistent with there being no problem with the data IDs being passed to PipelineTask, and hence this is ready to go back into review.
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for fixing this. Per your PM to me, I'm going to merge now so it gets in the weekly. We can sort out the question about `warnings.warn` after the Community discussion is over. I'm still not happy about the lack of local tests, but I think I understand why they are difficult, and I hope that other ticket makes them easier to implement.

            Show
            Parejkoj John Parejko added a comment - Thanks for fixing this. Per your PM to me, I'm going to merge now so it gets in the weekly. We can sort out the question about `warnings.warn` after the Community discussion is over. I'm still not happy about the lack of local tests, but I think I understand why they are difficult, and I hope that other ticket makes them easier to implement.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              erykoff Eli Rykoff
              Reviewers:
              John Parejko
              Watchers:
              Eli Rykoff, Ian Sullivan, Jim Bosch, John Parejko, Krzysztof Findeisen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.