Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28589

Publish the raw "move code" from the low-level ATDome controller

    XMLWordPrintable

    Details

      Description

      Update the ATDome CSC to publish the "move code" from line 5 of status from the low-level controller as a new event.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited

            I created a temporary version u/rowen/log_move_code without requiring a ts_xml update using branch u/rowen/log_move_code and tag v1.3.5.alpha.1

            Please run this and give me the information when you see commands failing to be reported as done and/or failure to report "in position".

            Please do not merge it to develop.

            Show
            rowen Russell Owen added a comment - - edited I created a temporary version u/rowen/log_move_code without requiring a ts_xml update using branch u/rowen/log_move_code and tag v1.3.5.alpha.1 Please run this and give me the information when you see commands failing to be reported as done and/or failure to report "in position". Please do not merge it to develop.
            Hide
            rowen Russell Owen added a comment - - edited

            I also:

            • Updated the code to use a new public MoveCode enum class.
            • Overhauled the code in the mock controller that computes the move code (including fixing a race condition).
            • Fixed some errors in test_csc.py (errors which suggest that the simulator was not outputting the correct move codes).
            • Enhanced test_csc.py to test the new moveCode event.

            Pull requests:

            Show
            rowen Russell Owen added a comment - - edited I also: Updated the code to use a new public MoveCode enum class. Overhauled the code in the mock controller that computes the move code (including fixing a race condition). Fixed some errors in test_csc.py (errors which suggest that the simulator was not outputting the correct move codes). Enhanced test_csc.py to test the new moveCode event. Pull requests: https://github.com/lsst-ts/ts_ATDome/pull/38 https://github.com/lsst-ts/ts_xml/pull/409
            Hide
            pkubanek Petr Kubanek added a comment -

            See comments in ts_ATDome. Improved code readibility, adds event with controller internal state.

            Show
            pkubanek Petr Kubanek added a comment - See comments in ts_ATDome. Improved code readibility, adds event with controller internal state.
            Hide
            rowen Russell Owen added a comment -

            Thank you for the helpful review. I updated to use |= to accumulate mask values in the mock controller, as you sensibly suggested. I am not ready to add the MoveCode enum to ts_xml and ts_idl because I consider the mask event an internal detail that is only exposed for debugging purposes, and it is a value that may change or go away. I am loath to make it easier to interpret lest clients start using it.

            Show
            rowen Russell Owen added a comment - Thank you for the helpful review. I updated to use |= to accumulate mask values in the mock controller, as you sensibly suggested. I am not ready to add the MoveCode enum to ts_xml and ts_idl because I consider the mask event an internal detail that is only exposed for debugging purposes, and it is a value that may change or go away. I am loath to make it easier to interpret lest clients start using it.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Petr Kubanek
              Watchers:
              Patrick Ingraham, Petr Kubanek, Russell Owen, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.