Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28597

Fix colorterm/photoCal filterLabel confusion

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Sprint:
      AP S21-3 (February), AP S21-4 (March)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Eli Rykoff brought to my attention that the existing PhotoCalTask, Colorterm, and jointcal code regarding reference catalog filters are all inconsistent in their use of physical/band filter labels. The colorterm dicts and getCorrectedMagnitude code should be changed to explicitly use physicalLabel (colorterms are associated with piece of glass), while refcat loading should be clarified to be band (you want the refcat filter name that is like the band of your science data). Jointcal and PhotoCalTask will likely need to pass around filterLabels as necessary, which will require a bit of reworking of jointcal's data loading mechanism. Cleaning up the docs and variable/method names is part of this work.

      As part of this, I will remove the now unnecessary filterMap (physical) and colortermDict (band) entries in obs_subaru and obs_cfht, to reduce confusion on this question.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            Eli Rykoff: I think I've go this mostly working except for fgcmcal. _computeOffsetOneBand creates an exposure and does setFilter(afwImage.Filter(band)), which is still using the deprecated interface, and also needs to have a non-empty physicalLabel, so that the colorterms work. It looks like FgcmOutputProductsTask run() and generateTractOutputProducts() both need to be updated to pass physical and band labels to _computeReferenceOffsets which passes them to _computeOffsetOneBand. I suspect you'd be able to fix that much quicker than I would.

            You'll want this ticket branch of pipe_tasks and obs_subaru to test it.

            Show
            Parejkoj John Parejko added a comment - Eli Rykoff : I think I've go this mostly working except for fgcmcal. _computeOffsetOneBand creates an exposure and does setFilter(afwImage.Filter(band)) , which is still using the deprecated interface, and also needs to have a non-empty physicalLabel, so that the colorterms work. It looks like FgcmOutputProductsTask run() and generateTractOutputProducts() both need to be updated to pass physical and band labels to _computeReferenceOffsets which passes them to _computeOffsetOneBand . I suspect you'd be able to fix that much quicker than I would. You'll want this ticket branch of pipe_tasks and obs_subaru to test it.
            Show
            Parejkoj John Parejko added a comment - Eli Rykoff : can you please review the non-fgcmcal changes, and I'll review those? https://github.com/lsst/jointcal/pull/174 https://github.com/lsst/obs_subaru/pull/352 https://github.com/lsst/obs_cfht/pull/84 https://github.com/lsst/pipe_tasks/pull/481
            Show
            Parejkoj John Parejko added a comment - - edited Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33925/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            Thank you to Eli Rykoff for the slightly complicated review process here, and to Krzysztof Findeisen for fixing DM-29313 so fast so that this could be included in this week's release.

            Show
            Parejkoj John Parejko added a comment - Thank you to Eli Rykoff for the slightly complicated review process here, and to Krzysztof Findeisen for fixing DM-29313 so fast so that this could be included in this week's release.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Eli Rykoff
              Watchers:
              Eli Rykoff, Ian Sullivan, John Parejko, Krzysztof Findeisen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.