Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28658

Modernize pybind11 wrappers for afw.display afw.cameraGeom afw.coord

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      4
    • Epic Link:
    • Sprint:
      DRP S21a (Dec Jan)
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      Note that this ticket has ended up also requiring a PR against display_firefly in addition to the packages named in the summary above.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28497 Modernize pybind11 wrappers for afw.math

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28727 Modernize pybind11 wrappers for afw.image

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-20286 Modernize pybind11 wrappers for afw.table and afw.table.io

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-20703 Modernize pybind11 wrappers for afw.fits, afw.geom

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            gpdf Gregory Dubois-Felsmann added a comment -

            Hi, Matthias Wittgen!  Nice to see you on this project!

            Trey Roby and I are working on another issue in display_firefly that is inhibiting cleaning up the new conda-based build system for Rubin code. We see your PR and will try to get it folded in during next week so that it makes it into next week's weekly, but if something else goes wrong with what we're doing we might not get there.

            Show
            gpdf Gregory Dubois-Felsmann added a comment - Hi, Matthias Wittgen !  Nice to see you on this project! Trey Roby  and I are working on another issue in  display_firefly that is inhibiting cleaning up the new conda-based build system for Rubin code. We see your PR and will try to get it folded in during next week so that it makes it into next week's weekly, but if something else goes wrong with what we're doing we might not get there.
            Hide
            Permalink
            wittgen Matthias Wittgen added a comment -

            Gregory Dubois-Felsmann nice for me as well!

            Jim Bosch, Krzysztof Findeisen you are probably very busy. This ticket is pending review. Could one of you have a look or suggest somebody else?

            Show
            wittgen Matthias Wittgen added a comment - Gregory Dubois-Felsmann  nice for me as well! Jim Bosch ,  Krzysztof Findeisen  you are probably very busy. This ticket is pending review. Could one of you have a look or suggest somebody else?
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I will take a look at it on Friday if not earlier.

            Show
            jbosch Jim Bosch added a comment - I will take a look at it on Friday if not earlier.
            Hide
            Permalink
            wittgen Matthias Wittgen added a comment -

            Thanks, no rush, the display_firefly change is only one line, can be rebased easily.

            Show
            wittgen Matthias Wittgen added a comment - Thanks, no rush, the display_firefly change is only one line, can be rebased easily.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Looks good; the couple of comments on the PR are very minor and half preexisting.

            Show
            jbosch Jim Bosch added a comment - Looks good; the couple of comments on the PR are very minor and half preexisting.

              People

              Assignee:
              wittgen Matthias Wittgen
              Reporter:
              wittgen Matthias Wittgen
              Reviewers:
              Jim Bosch
              Watchers:
              Gregory Dubois-Felsmann, Jim Bosch, Matthias Wittgen, Trey Roby
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.