Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28699

Update the Rotator Code to Reflect the Modified Circuit of Limit Switch

    XMLWordPrintable

    Details

      Description

      Update the rotator code to reflect the modified circuit of limit switch described in DM-28434. The codes of low-level controller and EUI should do the related modification. Otherwise, the system will always have the impression that the limit switch is triggered even though it is not, and block the system to enter the Enabled state to do the operation.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28615 Support the Summit Activity

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28434 Update the Hexapod Code to Reflect the Modified Circuit of Limit Switch

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment - - edited

            Updated the rotator GUI to reflect the updated circuit. I noticed the methods of get application status between the hexapod and rotator are different. The hexapod will use the Split Number Function and the rotator will not.

            Show
            ttsai Te-Wei Tsai added a comment - - edited Updated the rotator GUI to reflect the updated circuit. I noticed the methods of get application status between the hexapod and rotator are different. The hexapod will use the Split Number Function and the rotator will not.
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Added the test case of rotator GUI based on the real values on summit. The related test was recorded in DM-28615.

            Show
            ttsai Te-Wei Tsai added a comment - Added the test case of rotator GUI based on the real values on summit. The related test was recorded in DM-28615 .
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Please help to review the PRs:
            1. https://github.com/lsst-ts/ts_hexapod_controller/pull/8
            2. https://github.com/lsst-ts/ts_rotator_gui/pull/4
            3. https://github.com/lsst-ts/ts_rotator_controller/pull/14

            Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Please help to review the PRs: 1. https://github.com/lsst-ts/ts_hexapod_controller/pull/8 2. https://github.com/lsst-ts/ts_rotator_gui/pull/4 3. https://github.com/lsst-ts/ts_rotator_controller/pull/14 Thanks!
            Hide
            Permalink
            rowen Russell Owen added a comment -

            The parts I could review look very nice (I can't see the LabVIEW EUI changes). I had a few small suggestions on github. Thank you for this useful update.

            Show
            rowen Russell Owen added a comment - The parts I could review look very nice (I can't see the LabVIEW EUI changes). I had a few small suggestions on github. Thank you for this useful update.

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              ttsai Te-Wei Tsai
              Reviewers:
              Russell Owen
              Watchers:
              Russell Owen, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Start date:
                End date:

                  Jenkins

                  No builds found.