Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28810

Check that calexp FilterLabels are being contructed correctly in Gen2 and Gen3

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Urgent?:
      No

      Description

      Testing on DM-28583 revealed that even after the introduction of FilterLabel, as of w_2020_50, calexps were still being saved in Gen2 with no physicalLabel value in HSC.

      We should check whether this is still a problem (in both Gen2 and Gen3) on master, and if so, fix it.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            Known issue fixed in w_2021_06; see the Community thread for more details.

            Show
            krzys Krzysztof Findeisen added a comment - Known issue fixed in w_2021_06 ; see the Community thread for more details.
            Hide
            sullivan Ian Sullivan added a comment - - edited

            No, this was tested using the fix on DM-28583. There are more details on that ticket, but the problem appears to be that these calexps were written using an early version of FilterLabel and are in some intermediate state where the fix does not work. This suggests that calexps written using weekly w_2020_50 up until weekly w_2021_06 may not be readable with new code.

            Show
            sullivan Ian Sullivan added a comment - - edited No, this was tested using the fix on DM-28583 . There are more details on that ticket, but the problem appears to be that these calexps were written using an early version of FilterLabel and are in some intermediate state where the fix does not work. This suggests that calexps written using weekly w_2020_50 up until weekly w_2021_06 may not be readable with new code.
            Hide
            krzys Krzysztof Findeisen added a comment -

            DM-28583 did not fix anything, because it had a specific clause to ignore such files. Check the code if you don't believe me.

            Show
            krzys Krzysztof Findeisen added a comment - DM-28583 did not fix anything, because it had a specific clause to ignore such files. Check the code if you don't believe me.
            Hide
            jbosch Jim Bosch added a comment -

            It is my understanding that Krzysztof Findeisen's comment explains why the DM-28583 fix didn't work for Ian Sullivan, but that both of you are saying the exact same thing (and now I am, too):

            calexps written using weekly w_2020_50 up until weekly w_2021_06 may not be readable with new code

            But I now plan to modify the solution on DM-28583 so it will fix reading the files written in that time period as well. But I'll do that on DM-28583, so we can still close this ticket.

            (Maybe all of the confusion is whether Ian's "No, ..." was intended to negate the original ticket description or Krzysztof's reply - in any case, I hope we're all on the same page now.)

            Show
            jbosch Jim Bosch added a comment - It is my understanding that Krzysztof Findeisen 's comment explains why the DM-28583 fix didn't work for Ian Sullivan , but that both of you are saying the exact same thing (and now I am, too): calexps written using weekly w_2020_50 up until weekly w_2021_06 may not be readable with new code But I now plan to modify the solution on DM-28583 so it will fix reading the files written in that time period as well. But I'll do that on DM-28583 , so we can still close this ticket. (Maybe all of the confusion is whether Ian's "No, ..." was intended to negate the original ticket description or Krzysztof's reply - in any case, I hope we're all on the same page now.)
            Hide
            sullivan Ian Sullivan added a comment -

            Sorry for the confusion! I was referring to the Community post, since this represented a new bug that was not (yet!) fixed by DM-28583.

            Show
            sullivan Ian Sullivan added a comment - Sorry for the confusion! I was referring to the Community post, since this represented a new bug that was not (yet!) fixed by DM-28583 .

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              jbosch Jim Bosch
              Watchers:
              Ian Sullivan, Jim Bosch, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.