Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28863

Add metrics output and tests to gen3 jointcal

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: jointcal
    • Labels:
      None
    • Story Points:
      4
    • Epic Link:
    • Sprint:
      AP F21-5 (October)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      DM-27869 got gen3 jointcal working, but I skipped implementing a way to output measurements of the internal jointcal metrics due to lack of time. This ticket is to implement metric output, likely using one Connections.Output for each value. I might be able to keep using the Job object as place to hold the measurements until I `butler.put()` them.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20572 Remove "Generation 2" Middleware

          • Done
          has to be done before

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29542 Move jointcal cfht tests to gen3

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32601 Move remaining jointcal tests to gen3

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31966 Minimal viable pipetask python API

          • Done
          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27869 Create jointcal pipetask

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32135 Error in jointcal init when removing unneeded metrics

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31966 Minimal viable pipetask python API

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Blocking this on DM-31966, since I refactored the gen3 test code here to use the new pipetask API to help me with debugging.

            Show
            Parejkoj John Parejko added a comment - Blocking this on DM-31966 , since I refactored the gen3 test code here to use the new pipetask API to help me with debugging.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Simon Krughoff: are you available to do this moderate-sized (~250 lines) review? I changed a bunch of jointcal metric names in verify_metrics, updated them in jointcal, added metrics output and testing to the gen3 codepath, and updated the gen3 test to use the new pipetask python API. The commits should be atomic, so you can do the review per-commit, if it helps. Please let me know if this approach is the way to go to get these metrics loadable by SQuaSH.

            verify_metrics PR: https://github.com/lsst/verify_metrics/pull/29
            jointcal PR: https://github.com/lsst/jointcal/pull/195

            Nate Lust: do you mind reviewing just this commit on jointcal? In particular, I'm curious what you think about how I setup the config overrides (line 321). I don't want jointcal's tests to use the instrument-specific overrides, so I don't think I want to use the full pipeline config override stuff that you talked about in the slack thread, but I'm not sure whether this is the best approach.

            https://github.com/lsst/jointcal/pull/195/commits/e9cd166cea6e3b5a67fd9d5a6b492a9b02d83385

            Show
            Parejkoj John Parejko added a comment - Simon Krughoff : are you available to do this moderate-sized (~250 lines) review? I changed a bunch of jointcal metric names in verify_metrics, updated them in jointcal, added metrics output and testing to the gen3 codepath, and updated the gen3 test to use the new pipetask python API. The commits should be atomic, so you can do the review per-commit, if it helps. Please let me know if this approach is the way to go to get these metrics loadable by SQuaSH. verify_metrics PR: https://github.com/lsst/verify_metrics/pull/29 jointcal PR: https://github.com/lsst/jointcal/pull/195 Nate Lust : do you mind reviewing just this commit on jointcal? In particular, I'm curious what you think about how I setup the config overrides (line 321). I don't want jointcal's tests to use the instrument-specific overrides, so I don't think I want to use the full pipeline config override stuff that you talked about in the slack thread, but I'm not sure whether this is the best approach. https://github.com/lsst/jointcal/pull/195/commits/e9cd166cea6e3b5a67fd9d5a6b492a9b02d83385
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            Jenkins run (with DM-31966): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35120/pipeline

            Show
            Parejkoj John Parejko added a comment - - edited Jenkins run (with DM-31966 ): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35120/pipeline
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            I can have a look. I likely won't be until tomorrow.

            Show
            krughoff Simon Krughoff added a comment - I can have a look. I likely won't be until tomorrow.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Looks great. Two minor comments.

            Show
            krughoff Simon Krughoff added a comment - Looks great. Two minor comments.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Post review cleanup Jenkins (using the updated masters of ctrl_mpexec/pipe_base from DM-31966): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35142/pipeline

            Show
            Parejkoj John Parejko added a comment - Post review cleanup Jenkins (using the updated masters of ctrl_mpexec/pipe_base from DM-31966 ): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35142/pipeline

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Simon Krughoff
              Watchers:
              Ian Sullivan, John Parejko, Nate Lust, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.