Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2890

isrTask assumes that the Exposure has a Detector

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_isr
    • Labels:
      None

      Description

      While trying to use the isrTask to interpolate over bad columns in PTF data I discovered that the code assumes that the Exposure has a Detector attached.

      Please remove this restriction.

        Attachments

          Activity

          Hide
          rhl Robert Lupton added a comment -

          Pushed to github

          git diff --stat master
           python/lsst/ip/isr/isrTask.py | 4 ++++
           1 file changed, 4 insertions(+)
          

          Show
          rhl Robert Lupton added a comment - Pushed to github git diff --stat master python/lsst/ip/isr/isrTask.py | 4 ++++ 1 file changed, 4 insertions(+)
          Hide
          yusra Yusra AlSayyad added a comment -

          Before merging:

          • Please update the part of the task documentation (starts line 267) that says IsrTask.run requires exposures to have an afw.cameraGeom.Detector. With this change, this is no longer accurate.
          • please make clear to users who pass an exposure without a Detector, that the following steps won't get run: updateVariance, saturationDetection and overscanCorrection.
          Show
          yusra Yusra AlSayyad added a comment - Before merging: Please update the part of the task documentation (starts line 267) that says IsrTask.run requires exposures to have an afw.cameraGeom.Detector . With this change, this is no longer accurate. please make clear to users who pass an exposure without a Detector, that the following steps won't get run: updateVariance , saturationDetection and overscanCorrection .
          Hide
          rhl Robert Lupton added a comment -

          I have updated the task as requested, but also went ahead and added a fake Amp object to allow updateVariance and saturationDetection to be run if requested. Would you like to take another look, or shall I merge to master?

          Show
          rhl Robert Lupton added a comment - I have updated the task as requested, but also went ahead and added a fake Amp object to allow updateVariance and saturationDetection to be run if requested. Would you like to take another look, or shall I merge to master?
          Hide
          yusra Yusra AlSayyad added a comment -

          Merge away!

          Show
          yusra Yusra AlSayyad added a comment - Merge away!
          Hide
          rhl Robert Lupton added a comment -

          $ git merge --no-ff tickets/DM-2890
          Merge made by the 'recursive' strategy.
           python/lsst/ip/isr/isr.py     |  2 +-
           python/lsst/ip/isr/isrTask.py | 88 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------
           2 files changed, 75 insertions(+), 15 deletions(-)
          $ git push
          Counting objects: 1, done.
          Writing objects: 100% (1/1), 244 bytes | 0 bytes/s, done.
          Total 1 (delta 0), reused 0 (delta 0)
          To git@github.com:lsst/ip_isr
             19f7783..60126f8  master -> master
          

          Show
          rhl Robert Lupton added a comment - $ git merge --no-ff tickets/DM-2890 Merge made by the 'recursive' strategy. python/lsst/ip/isr/isr.py | 2 +- python/lsst/ip/isr/isrTask.py | 88 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------- 2 files changed, 75 insertions(+), 15 deletions(-) $ git push Counting objects: 1, done. Writing objects: 100% (1/1), 244 bytes | 0 bytes/s, done. Total 1 (delta 0), reused 0 (delta 0) To git@github.com:lsst/ip_isr 19f7783..60126f8 master -> master

            People

            • Assignee:
              rhl Robert Lupton
              Reporter:
              rhl Robert Lupton
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Robert Lupton, Yusra AlSayyad
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel