Robert Lupton added a comment - 06/Jun/15 8:32 AM Pushed to github git diff --stat master python/lsst/ip/isr/isrTask.py | 4 ++++ 1 file changed, 4 insertions(+)

Yusra AlSayyad added a comment - 06/Jun/15 11:31 PM Before merging: Please update the part of the task documentation (starts line 267) that says IsrTask.run requires exposures to have an afw.cameraGeom.Detector . With this change, this is no longer accurate. please make clear to users who pass an exposure without a Detector, that the following steps won't get run: updateVariance , saturationDetection and overscanCorrection .

Robert Lupton added a comment - 11/Jun/15 4:36 PM I have updated the task as requested, but also went ahead and added a fake Amp object to allow updateVariance and saturationDetection to be run if requested. Would you like to take another look, or shall I merge to master?

Robert Lupton added a comment - 12/Jun/15 9:21 AM $ git merge --no-ff tickets/DM-2890 Merge made by the 'recursive' strategy. python/lsst/ip/isr/isr.py | 2 +- python/lsst/ip/isr/isrTask.py | 88 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------- 2 files changed, 75 insertions(+), 15 deletions(-) $ git push Counting objects: 1, done. Writing objects: 100% (1/1), 244 bytes | 0 bytes/s, done. Total 1 (delta 0), reused 0 (delta 0) To git@github.com:lsst/ip_isr 19f7783..60126f8 master -> master