Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_algorithms
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:DRP S17-5, DRP S17-6, DRP F17-1, DRP F17-2, DRP F17-3, DRP F17-4, DRP F17-5, DRP F17-6, DRP S18-1, DRP S18-2, DRP S18-3, DRP S18-4, DRP S18-5, DRP S18-6, DRP F18-1, DRP F18-2, DRP F18-3, DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1, DRP S19-2, DRP S19-3, DRP S19-4, DRP S19-5, DRP S19-6a, DRP S19-6b
-
Team:Data Release Production
Description
meas.algorithms.utils uses GaussianCentroid and SdssShape, but now that they have moved to meas_base the code no longer works.
Please fix this. I'd prefer to leave the functionality to visualise PSFs in meas_algorithms, but if necessary file an RFC to move it elsewhere.
Attachments
Issue Links
- relates to
-
- To Do
Activity
Here it is: DM-9517. I have a script which I can use to fix the unit tests when I merge this ticket.
The unit test did not work even using lsst.afw.display.ds9 with the existing import statement, so the goal on this ticket is to make it at least work.
Perry Gee
added a comment - Here it is: DM-9517 . I have a script which I can use to fix the unit tests when I merge this ticket.
The unit test did not work even using lsst.afw.display.ds9 with the existing import statement, so the goal on this ticket is to make it at least work. Tim Morton [X] — This has been reviewed but unmerged for the better part of two years now. What's the current status? Is it still useful?
OK I took a look at this PR. The code changes have been already done in DM-13432. In the name of test coverage, I'm going to quickly rebase that commit and see if it runs and passes Jenkins. If it does, just the unit test is going in, and we're closing this.
Rebased/Fixed up the unit test.
Tim Morton [X] reviewed since his name will be on the commit.
Jenkins passed https://ci.lsst.codes/job/stack-os-matrix/29918/display/redirect
Merged to master.
Yes, but not on this ticket. I already made the change RHL suggests under my own open pull request, so it will automatically get made to this code when I merge before checkin.