Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-28926

Update my configurable CSCs to store the schema as code

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      TSSW Sprint - Feb 15 - Mar 1, TSSW Sprint - Mar 1 - Mar 15
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      ts_salobj 6.3 has deprecated saving the schema as a separate file. Update my CSCs to save it as code and specify it using the new config_schema constructor argument.

      Don't forget to update the unit tests in the asociated ts_config_x packages.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28917 Allow configurable CSCs to store their config schema as code

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28892 Improve help for the --simulate command-line argument in ts_salobj

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Pull requests:

            Show
            rowen Russell Owen added a comment - - edited Pull requests: https://github.com/lsst-ts/ts_ATDome/pull/42 https://github.com/lsst-ts/ts_ATDomeTrajectory/pull/33 https://github.com/lsst-ts/ts_config_attcs/pull/17 https://github.com/lsst-ts/ts_config_mttcs/pull/17 https://github.com/lsst-ts/ts_config_ocs/pull/30 https://github.com/lsst-ts/ts_FiberSpectrograph/pull/24 https://github.com/lsst-ts/ts_hexrotcomm/pull/33 https://github.com/lsst-ts/ts_MTDomeTrajectory/pull/13 https://github.com/lsst-ts/ts_mthexapod/pull/40 https://github.com/lsst-ts/ts_mtrotator/pull/39 https://github.com/lsst-ts/ts_watcher/pull/30
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            All PRs were reviewed and approved though I did leave one or more minor comments for all of them.

            Show
            wvreeven Wouter van Reeven added a comment - All PRs were reviewed and approved though I did leave one or more minor comments for all of them.
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            I implemented all the suggested changes and removed schema from the source section of conda/meta.yaml.
            However, I didn't change boilerplate if it was already close (some version of Vera C. Rubin Observatory)
            and used something slightly different for the packages that were using LSST than I later found in ts_hexrotcomm, etc.
            Once we have a published standard we can decide whether to fix packages that are close.

            Releases:

            • ts_ATDome v1.5.0
            • ts_ATDomeTrajectory v1.5.0
            • ts_config_attcs v0.7.0
            • ts_config_mttcs v0.7.0
            • ts_config_ocs v0.9.0
            • ts_FiberSpectrograph v0.4.0
            • ts_hexrotcomm v0.16.0
            • ts_idl v3.1.1
            • ts_mthexapod v0.15.0
            • ts_mtrotator v0.13.0
            • ts_MTDomeTrajectory v0.5.0
            • ts_salobj v6.3.0
            • ts_watcher v1.5.0
            Show
            rowen Russell Owen added a comment - - edited I implemented all the suggested changes and removed schema from the source section of conda/meta.yaml. However, I didn't change boilerplate if it was already close (some version of Vera C. Rubin Observatory) and used something slightly different for the packages that were using LSST than I later found in ts_hexrotcomm, etc. Once we have a published standard we can decide whether to fix packages that are close. Releases: ts_ATDome v1.5.0 ts_ATDomeTrajectory v1.5.0 ts_config_attcs v0.7.0 ts_config_mttcs v0.7.0 ts_config_ocs v0.9.0 ts_FiberSpectrograph v0.4.0 ts_hexrotcomm v0.16.0 ts_idl v3.1.1 ts_mthexapod v0.15.0 ts_mtrotator v0.13.0 ts_MTDomeTrajectory v0.5.0 ts_salobj v6.3.0 ts_watcher v1.5.0

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Wouter van Reeven
              Watchers:
              Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.