Thanks for the review. I think I addressed all your comments, including your not liking the parquet inputs. I swapped them out for the new ExposureCatalog `visitSummary`. (This was needed anyway when I add MJD bounds next ticket). With
DM-29407 on master from last week, it’s super fast. My test run with 33 visits now takes <4s.
The idea was that BestSeeingSelectVisitTask, would be close to your original BestSeeingSelectImagesTask so that it’d look familiar and you could maintain along with the old Gen2 tasks. This was intended to be the task you maintained for AP, so I’m happy to make any edits you’d like to it. If you’re free to pair-code Tues/Wed, I’ll change all the variable names and default configs to whatever you want.
BestSeeeingQuantileSelectVisitsTask is the new one I’m planning going to use for DRP.
And now that visitSummary has the info, I also added a double check that the visits do indeed overlap the patch. This probably could be refined in the future to use getValidPolygon instead of the corners.
And whoops, need to "Ask for Review"