Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29019

Make obs_lsst data ID packing consistent

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      The HSC/daf.butler.DimensionPacker logic for how to pack visit/exposure+detector data IDs into integers doesn't agree with the detector_max values in obs_lsst. Update the latter, and make sure that doesn't have an unexpected repercussions.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          jbosch Jim Bosch added a comment -

          Tim Jenness, another small visit/exposure/detector-ID-related review for you (what we discussed on Slack yesterday). Really wish we had time to go clean this all up now, as you laid out on that other ticket, but in the meantime I think this makes things more consistent in an important way (i.e. compute_detector_exposure_id and DimensionPacker will agree for obs_lsst) until we get a chance.

          PR is https://github.com/lsst/obs_lsst/pull/293

          Show
          jbosch Jim Bosch added a comment - Tim Jenness , another small visit/exposure/detector-ID-related review for you (what we discussed on Slack yesterday). Really wish we had time to go clean this all up now, as you laid out on that other ticket, but in the meantime I think this makes things more consistent in an important way (i.e. compute_detector_exposure_id and DimensionPacker will agree for obs_lsst) until we get a chance. PR is https://github.com/lsst/obs_lsst/pull/293
          Hide
          Permalink
          tjenness Tim Jenness added a comment -

          Looks good. Getting rid of the concat mode makes it match daf_butler by design so that's the right answer.

          Show
          tjenness Tim Jenness added a comment - Looks good. Getting rid of the concat mode makes it match daf_butler by design so that's the right answer.

            People

            Assignee:
            jbosch Jim Bosch
            Reporter:
            jbosch Jim Bosch
            Reviewers:
            Tim Jenness
            Watchers:
            Jim Bosch, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.