Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29041

Support repository names as ap_verify --dataset argument and deprecate old names

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • ap_verify
    • None

    Description

      Allow the --dataset argument to ap_verify.py and related scripts to take the repository name. Raise a deprecation warning any time an old-style argument is processed.

      Attachments

        Issue Links

          Activity

            krzys Krzysztof Findeisen added a comment - - edited

            I believe that the special-casing for ap_verify_testdata can be removed on this ticket – since all references to the dataset should be internal anyway, I can update them to use the repository name immediately.

            Edit: some references to the special name for ap_verify_testdata remain in test_dataset.py, in order to test the deprecation mechanism.

            krzys Krzysztof Findeisen added a comment - - edited I believe that the special-casing for ap_verify_testdata can be removed on this ticket – since all references to the dataset should be internal anyway, I can update them to use the repository name immediately. Edit: some references to the special name for ap_verify_testdata remain in test_dataset.py , in order to test the deprecation mechanism.

            I'm partway through; so far the changes to pipeline_driver.py and ap_verify.yaml look fine, and I'm working on add_gen3_repo.py now. I plan to finish all today.

            kherner Kenneth Herner added a comment - I'm partway through; so far the changes to pipeline_driver.py and ap_verify.yaml look fine, and I'm working on add_gen3_repo.py now. I plan to finish all today.

            Nearly done, but I have one question on add_gen3_repo.py. I see you've hard-coded two names here: 

             contents.saveCollection("skymaps")
             contents.saveCollection("templates/deep")

            Are these always guaranteed to be correct (maybe it's fine because it's ap_verify) or should they come from some config value?

            kherner Kenneth Herner added a comment - Nearly done, but I have one question on add_gen3_repo.py. I see you've hard-coded two names here:   contents.saveCollection("skymaps")  contents.saveCollection("templates/deep") Are these always guaranteed to be correct (maybe it's fine because it's ap_verify) or should they come from some config value?

            I've pushed fixes to ap_verify_dataset_template and ap_verify. Can you take another look, and mark this ticket as reviewed if you're happy?

            krzys Krzysztof Findeisen added a comment - I've pushed fixes to ap_verify_dataset_template and ap_verify . Can you take another look, and mark this ticket as reviewed if you're happy?

            People

              krzys Krzysztof Findeisen
              krzys Krzysztof Findeisen
              Kenneth Herner
              Kenneth Herner, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.