Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29041

Support repository names as ap_verify --dataset argument and deprecate old names

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ap_verify
    • Labels:
      None

      Description

      Allow the --dataset argument to ap_verify.py and related scripts to take the repository name. Raise a deprecation warning any time an old-style argument is processed.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-25629 Do release 22.0.0 of science pipelines

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29042 Remove support for old-style names in ap_verify

          • Done
          has to be done before

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29040 Use repository name as ci_dataset tag in ap_verify SQuaSH uploads

          • Invalid
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-758 Deprecate ap_verify datasets' user-facing names

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment - - edited

            I believe that the special-casing for ap_verify_testdata can be removed on this ticket – since all references to the dataset should be internal anyway, I can update them to use the repository name immediately.

            Edit: some references to the special name for ap_verify_testdata remain in test_dataset.py, in order to test the deprecation mechanism.

            Show
            krzys Krzysztof Findeisen added a comment - - edited I believe that the special-casing for ap_verify_testdata can be removed on this ticket – since all references to the dataset should be internal anyway, I can update them to use the repository name immediately. Edit: some references to the special name for ap_verify_testdata remain in test_dataset.py , in order to test the deprecation mechanism.
            Hide
            Permalink
            kherner Kenneth Herner added a comment -

            I'm partway through; so far the changes to pipeline_driver.py and ap_verify.yaml look fine, and I'm working on add_gen3_repo.py now. I plan to finish all today.

            Show
            kherner Kenneth Herner added a comment - I'm partway through; so far the changes to pipeline_driver.py and ap_verify.yaml look fine, and I'm working on add_gen3_repo.py now. I plan to finish all today.
            Hide
            Permalink
            kherner Kenneth Herner added a comment -

            Nearly done, but I have one question on add_gen3_repo.py. I see you've hard-coded two names here: 

             contents.saveCollection("skymaps")
             contents.saveCollection("templates/deep")

            Are these always guaranteed to be correct (maybe it's fine because it's ap_verify) or should they come from some config value?

            Show
            kherner Kenneth Herner added a comment - Nearly done, but I have one question on add_gen3_repo.py. I see you've hard-coded two names here:   contents.saveCollection("skymaps")  contents.saveCollection("templates/deep") Are these always guaranteed to be correct (maybe it's fine because it's ap_verify) or should they come from some config value?
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            I've pushed fixes to ap_verify_dataset_template and ap_verify. Can you take another look, and mark this ticket as reviewed if you're happy?

            Show
            krzys Krzysztof Findeisen added a comment - I've pushed fixes to ap_verify_dataset_template and ap_verify . Can you take another look, and mark this ticket as reviewed if you're happy?

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Kenneth Herner
              Watchers:
              Kenneth Herner, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.