Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29053

Don't send quantities to GGCorrelation

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • faro

    Description

      Currently the the utility code in faro/utils/tex.py send astropy.units.quanty objects to GGCorrelation. That works, but since GGCorrelation knows nothing about quantities, it results in a significant slowdown. If quantities are needed, they should be generated from the outputs and passed on from there.

      Attachments

        Issue Links

          Activity

            kbechtol Keith Bechtol added a comment - See this PR: https://github.com/lsst/faro/pull/79
            kbechtol Keith Bechtol added a comment - - edited

            This was done in the now merged PR: https://github.com/lsst/faro/pull/79

            See specifically python/lsst/faro/utils/tex.py that arrays without associated astropy quantities are used as the input.

            kbechtol Keith Bechtol added a comment - - edited This was done in the now merged PR: https://github.com/lsst/faro/pull/79 See specifically python/lsst/faro/utils/tex.py that arrays without associated astropy quantities are used as the input.

            Marking done based on the above comment.

            krughoff Simon Krughoff (Inactive) added a comment - Marking done based on the above comment.

            People

              kbechtol Keith Bechtol
              krughoff Simon Krughoff (Inactive)
              Jeffrey Carlin
              Jeffrey Carlin, Keith Bechtol, Simon Krughoff (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.