Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29053

Don't send quantities to GGCorrelation

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: faro
    • Labels:

      Description

      Currently the the utility code in faro/utils/tex.py send astropy.units.quanty objects to GGCorrelation. That works, but since GGCorrelation knows nothing about quantities, it results in a significant slowdown. If quantities are needed, they should be generated from the outputs and passed on from there.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-26988 Update TE1 and TE2 metric implementations

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            kbechtol Keith Bechtol added a comment -

            See this PR: https://github.com/lsst/faro/pull/79

            Show
            kbechtol Keith Bechtol added a comment - See this PR: https://github.com/lsst/faro/pull/79
            Hide
            Permalink
            kbechtol Keith Bechtol added a comment - - edited

            This was done in the now merged PR: https://github.com/lsst/faro/pull/79

            See specifically python/lsst/faro/utils/tex.py that arrays without associated astropy quantities are used as the input.

            Show
            kbechtol Keith Bechtol added a comment - - edited This was done in the now merged PR: https://github.com/lsst/faro/pull/79 See specifically python/lsst/faro/utils/tex.py that arrays without associated astropy quantities are used as the input.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Marking done based on the above comment.

            Show
            krughoff Simon Krughoff added a comment - Marking done based on the above comment.

              People

              Assignee:
              kbechtol Keith Bechtol
              Reporter:
              krughoff Simon Krughoff
              Reviewers:
              Jeffrey Carlin
              Watchers:
              Jeffrey Carlin, Keith Bechtol, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.