Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29069

statsControl.setNumIter(0) kills python/kernels

    XMLWordPrintable

    Details

    • Urgent?:
      No

      Description

      Obviously it's a dumb "just don't do that" kind of thing, but if you just

      import lsst.afw.math as afwMath
      sctrl = afwMath.StatisticsControl()
      sctrl.setNumIter(0)

      then you get a C++ assertion error, but things then propagate in a way that kills python/your kernel.

        Attachments

          Activity

          Hide
          kannawad Arun Kannawadi added a comment -

          https://github.com/lsst/afw/tree/tickets/DM-29069

          I'm not sure why but the branch isn't showing up on Jira. There are two possible ways (in two different commits) of fixing it - either by checking the input parameter at the pybind11 layer and throwing an exception, or doing that within the C++ layer. It makes sense to reserve `assert` in a method to assert the method performed as excepted, rather than asserting that it received inputs as expected. So I'm for dropping the commit that throws the exception from pybind11.

          Show
          kannawad Arun Kannawadi added a comment - https://github.com/lsst/afw/tree/tickets/DM-29069 I'm not sure why but the branch isn't showing up on Jira. There are two possible ways (in two different commits) of fixing it - either by checking the input parameter at the pybind11 layer and throwing an exception, or doing that within the C++ layer. It makes sense to reserve `assert` in a method to assert the method performed as excepted, rather than asserting that it received inputs as expected. So I'm for dropping the commit that throws the exception from pybind11.
          Show
          kannawad Arun Kannawadi added a comment - Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/34142/pipeline
          Show
          kannawad Arun Kannawadi added a comment - Successful Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/34146/pipeline
          Hide
          mschmitz Morgan Schmitz added a comment -

          LGTM (once the commits are cleaned up)!

          Show
          mschmitz Morgan Schmitz added a comment - LGTM (once the commits are cleaned up)!
          Hide
          kannawad Arun Kannawadi added a comment -

          Discarded the changes to `_statistics.cc` and merged.

          Show
          kannawad Arun Kannawadi added a comment - Discarded the changes to `_statistics.cc` and merged.

            People

            Assignee:
            kannawad Arun Kannawadi
            Reporter:
            mfisherlevine Merlin Fisher-Levine
            Reviewers:
            Morgan Schmitz
            Watchers:
            Arun Kannawadi, Jim Bosch, Merlin Fisher-Levine, Morgan Schmitz
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                CI Builds

                No builds found.