Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2910

obs_cfht is broken with the current stack

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • obs_cfht
    • None
    • 1
    • Science Pipelines DM-S15-4, Science Pipelines DM-S15-5
    • Alert Production

    Description

      obs_cfht's camera mapper is missing the new packageName class variable, so it is not compatible with the current stack.

      I suggest fixing obs_sdss and obs_subaru as well, if they need it.

      Attachments

        Issue Links

          Activity

            tjenness Tim Jenness added a comment -

            Is this related to DM-2789 ?

            tjenness Tim Jenness added a comment - Is this related to DM-2789 ?

            Yes, I believe so

            rowen Russell Owen added a comment - Yes, I believe so
            rowen Russell Owen added a comment - - edited

            I have pushed fixes to obs_cfht and obs_subaru on tickets/DM-2910. These include a test of the new name.

            I tried running obs_cfht tests but it turns out they are broken. I filed DM-2917.

            rowen Russell Owen added a comment - - edited I have pushed fixes to obs_cfht and obs_subaru on tickets/ DM-2910 . These include a test of the new name. I tried running obs_cfht tests but it turns out they are broken. I filed DM-2917 .
            rowen Russell Owen added a comment -

            Lauren: would you be willing to review these small changes? I figured you might even be able to build obs_subaru and run the tests (something I cannot do).

            Note: I won't merge until I manage to get the obs_cfht code run with testdata_cfht

            rowen Russell Owen added a comment - Lauren: would you be willing to review these small changes? I figured you might even be able to build obs_subaru and run the tests (something I cannot do). Note: I won't merge until I manage to get the obs_cfht code run with testdata_cfht
            rowen Russell Owen added a comment -

            I added one more fix, which fits under the title, though it is a different problem than I originally had in mind when I wrote the ticket: config/processCcd.py override file uses the wrong path to get to the color term data.

            rowen Russell Owen added a comment - I added one more fix, which fits under the title, though it is a different problem than I originally had in mind when I wrote the ticket: config/processCcd.py override file uses the wrong path to get to the color term data.

            Sure, I'll have a look (after I finish a review for rhl, so may take a few days).

            lauren Lauren MacArthur added a comment - Sure, I'll have a look (after I finish a review for rhl, so may take a few days).

            I made some minor comments to a few commits on GitHub. Once addressed you are good to merge.

            lauren Lauren MacArthur added a comment - I made some minor comments to a few commits on GitHub. Once addressed you are good to merge.
            rowen Russell Owen added a comment -

            Merged to master June 17

            rowen Russell Owen added a comment - Merged to master June 17

            People

              rowen Russell Owen
              rowen Russell Owen
              Lauren MacArthur
              Joshua Hoblitt, Lauren MacArthur, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.