Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_deblender, pipe_tasks
-
Labels:None
-
Story Points:10
-
Epic Link:
-
Sprint:Science Pipelines DM-S15-5, Science Pipelines DM-S15-6
-
Team:Data Release Production
Description
Attachments
Activity
Paul, would you mind giving this a review? I think you are pretty familiar with all the changes. You should see all the u/lauren/DM-2914 branches on the tab to the right (ignore the jbosch one).
A Jenkins build was successful.
One small concern:
- In obs_subaru commit a52e24f, there seems to be more introduced than what's in the commit message (specifically, filterMap stuff, which I fear may conflict with changes recently made on master).
Otherwise, looks good, thanks.
Paul Price
added a comment - One small concern:
In obs_subaru commit a52e24f , there seems to be more introduced than what's in the commit message (specifically, filterMap stuff, which I fear may conflict with changes recently made on master).
Otherwise, looks good, thanks. Thanks Paul Price. You were right about the filterMap additions (they got mixed up in a conflict and my resolution choice was the wrong one!). I removed them in a fixup. I also rebased all branches onto the latest master and reran a Jenkins build. It succeeded so I pushed to master.
Could you add a brief note to https://confluence.lsstcorp.org/display/DM/Data+Release+Production+WIP+S15+release+notes describing what changed here, please? Thanks!
Adding the meas_deblender commit from HSC-1116.
And the meas_deblender commit from HSC-1147.
And the meas_deblender and afw commits from HSC-1004.
And the meas_deblender commits from HSC-1260 which used to be
DM-2975(now a Won't Fix). Also absorb here the 2 story points fromDM-2975.And the floating afw commit (a commit neglected in HSC-1274).