Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: pipe_tasks
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Science Pipelines DM-S15-4
-
Team:Alert Production
Description
When I implemented DM-2797 I made a few errors in pipe_tasks:
- PhotoCalTask mis-calls two methods of Colorterm by providing filterName, which is not needed
- ColortermLibrary.getColorterm mis-handles glob expressions (the two arguments to fnmatch.fnmatch are swapped).
We also need a unit test for applying colorterms, but that will require enough work that I have made a separate ticket for it: DM-2918. Meanwhile I have tested my changes by running Dominique's CFHT demo. This proves that the colorterm code runs, but does not prove that the terms are correctly applied.
Echoing what I said in the pull request, I'm not sure the change to fnmatch is needed. I would also like to see the unit test as part of this ticket, but if it's too much work I can be convinced to do it elsewhere.