Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2919

PhotoCalTask mis-calling Colorterm methods

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Templates:
    • Story Points:
      1
    • Sprint:
      Science Pipelines DM-S15-4
    • Team:
      Alert Production

      Description

      When I implemented DM-2797 I made a few errors in pipe_tasks:

      • PhotoCalTask mis-calls two methods of Colorterm by providing filterName, which is not needed
      • ColortermLibrary.getColorterm mis-handles glob expressions (the two arguments to fnmatch.fnmatch are swapped).

      We also need a unit test for applying colorterms, but that will require enough work that I have made a separate ticket for it: DM-2918. Meanwhile I have tested my changes by running Dominique's CFHT demo. This proves that the colorterm code runs, but does not prove that the terms are correctly applied.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Simon Krughoff
                Watchers:
                Lauren MacArthur, Russell Owen, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel