Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29218

Prevent double header fixup in astro_metadata_translator

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      In DM-29187 it was noted that it is trivial to cause a double fix up of headers.

      Currently there is no way for astro_metadata_translator to know if a fixup has already been applied to the header.

      Add a sentinel value to the header when fixed.

      This has to be added as a keyword that will not be confusing. I am going to start by trying HIERARCH ASTROMETADATA FIXED = T.

        Attachments

          Issue Links

          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29286 Clean up header equality checks involving provenance

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29275 Fix problem in obs_base from fix_header provenance

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29187 LATISS UTC/TAI problems were fixed on 2021-02-12

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Robert Lupton this now fixes the double-header fixup problem. I've added new HIERARCH keywords to the header with fix up provenance including whether the header was modified, the date of modification, the version of the translator used, and any correction file that was used.

            Show
            tjenness Tim Jenness added a comment - Robert Lupton this now fixes the double-header fixup problem. I've added new HIERARCH keywords to the header with fix up provenance including whether the header was modified, the date of modification, the version of the translator used, and any correction file that was used.
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Minor comment on the pull request.

            Show
            rhl Robert Lupton added a comment - Minor comment on the pull request.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Robert Lupton
              Watchers:
              Robert Lupton, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.