Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2923

Port HSC-1199 to LSST (UNMASKEDNAN mask propagates to all amplifiers)

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_isr
    • Labels:
      None

      Description

      Port issue HSC-1199 to LSST stack to address UNMASKEDNAN mask propagates to all amplifiers

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          7 older comments
          Hide
          Permalink
          nlust Nate Lust added a comment -

          Fix-up has been squashed. The changes have been run through buildbot, and the unittest suite independently. I was able to hack together code that would fail before the changes and pass after the changes. I have noted future changes which should be considered for overscan correction in DM-3589. I additionally added new documentation to make certain parts of the code more understandable for future developers.

          Show
          nlust Nate Lust added a comment - Fix-up has been squashed. The changes have been run through buildbot, and the unittest suite independently. I was able to hack together code that would fail before the changes and pass after the changes. I have noted future changes which should be considered for overscan correction in DM-3589 . I additionally added new documentation to make certain parts of the code more understandable for future developers.
          Hide
          Permalink
          lauren Lauren MacArthur added a comment -

          Looks good modulo a few minor typos in your last commit (comments on GitHub). Fix those and you are free to merge. Thanks for creating the other ticket.

          Show
          lauren Lauren MacArthur added a comment - Looks good modulo a few minor typos in your last commit (comments on GitHub). Fix those and you are free to merge. Thanks for creating the other ticket.
          Hide
          Permalink
          nlust Nate Lust added a comment -

          Merged to master

          Show
          nlust Nate Lust added a comment - Merged to master
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          Could you add a brief note to https://confluence.lsstcorp.org/display/DM/Data+Release+Production+WIP+S15+release+notes describing what changed here, please? Thanks!

          Show
          swinbank John Swinbank added a comment - Could you add a brief note to https://confluence.lsstcorp.org/display/DM/Data+Release+Production+WIP+S15+release+notes describing what changed here, please? Thanks!
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          Reminder to update the release notes!

          Show
          swinbank John Swinbank added a comment - Reminder to update the release notes!

            People

            Assignee:
            nlust Nate Lust
            Reporter:
            nlust Nate Lust
            Reviewers:
            Lauren MacArthur
            Watchers:
            John Swinbank, Lauren MacArthur, Nate Lust
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.