Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2924

Support EQUINOX being "J2000.0" as well as 2000.0

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None

      Description

      I share the concern that we're going to spend a lot of effort on handling illegal WCS headers, but this one's easy, and we already have a partial fix for the SDSS headers which use a string but no "J" prefix.

      Skymapper uses "J2000.0" not 2000.0 for its EQUINOX. Our code silently converts this to float using atof, and thus interprets it as 0.0 and deduces FK4 (which we don't support).

        Attachments

          Activity

          rhl Robert Lupton created issue -
          Hide
          rhl Robert Lupton added a comment -

          A one liner.

          No test, but I checked that it works on Skyserver files so I think it's safe.

          Show
          rhl Robert Lupton added a comment - A one liner. No test, but I checked that it works on Skyserver files so I think it's safe.
          rhl Robert Lupton made changes -
          Field Original Value New Value
          Reviewers Tim Jenness [ tjenness ]
          Status To Do [ 10001 ] In Review [ 10004 ]
          Hide
          tjenness Tim Jenness added a comment -

          Looks okay, but can you add a comment before the code explaining the insanity. Otherwise someone is bound to come along in a couple of years and think we are crazy.

          Show
          tjenness Tim Jenness added a comment - Looks okay, but can you add a comment before the code explaining the insanity. Otherwise someone is bound to come along in a couple of years and think we are crazy.
          tjenness Tim Jenness made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          rhl Robert Lupton made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          Hide
          rhl Robert Lupton added a comment -

          Added comment and merged to master

          Show
          rhl Robert Lupton added a comment - Added comment and merged to master
          swinbank John Swinbank made changes -
          Epic Link DM-1912 [ 15945 ]
          swinbank John Swinbank made changes -
          Sprint Science Pipelines DM-S15-4 [ 159 ]
          Team Data Release Production [ 10301 ]

            People

            • Assignee:
              rhl Robert Lupton
              Reporter:
              rhl Robert Lupton
              Reviewers:
              Tim Jenness
              Watchers:
              Robert Lupton, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: