Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29264

Update phosim_syseng4 for ComCam

    XMLWordPrintable

Details

    • Improvement
    • Status: Done
    • Resolution: Done
    • None
    • ts_aos

    Description

      Update the data/comcam segmentation.txt  gain and read noise values and focalplanelayout.txt geometry (x,y position, overscan,prescan), sensor names, to make them consistent with those in obs_lsst for lsst.obs.lsst.LsstComCam instrument (i.e. R22 is ITL - https://github.com/lsst/obs_lsst/blob/master/policy/comCam/R22.yaml ). Use the new values from DM-28919 (https://github.com/lsst/obs_lsst/pull/292/files) 

      Attachments

        Issue Links

          Activity

            ksuberlak Krzysztof Suberlak added a comment - - edited

            This involved making changes to phosim_utils to use LsstComCam instrument - PR#13 https://github.com/lsst-dm/phosim_utils/pull/13  - that are already merged. Released as phosim_utils  v.0.2.1.   Also made an update to obs_lsst to recognize phosim-looking-like-comcam files and properly translate the heade -  PR#298  was merged https://github.com/lsst/obs_lsst/pull/298  . 

            ksuberlak Krzysztof Suberlak added a comment - - edited This involved making changes to phosim_utils to use LsstComCam instrument - PR#13 https://github.com/lsst-dm/phosim_utils/pull/13   - that are already merged. Released as phosim_utils  v.0.2.1.   Also made an update to obs_lsst to recognize phosim-looking-like-comcam files and properly translate the heade -  PR#298  was merged  https://github.com/lsst/obs_lsst/pull/298   . 

            Opened PR#14  to phosim_utils to mimic obs_lsst comcam filter names to enable ingest into gen3 butler repo.

            ksuberlak Krzysztof Suberlak added a comment - Opened PR#14  to phosim_utils to mimic obs_lsst comcam filter names to enable ingest into gen3 butler repo.

            Created DM-29424 to enable boresight translation for comCam.py in obs_lsst and make new tests for test_translator.py . 

            ksuberlak Krzysztof Suberlak added a comment - Created  DM-29424 to enable boresight translation for comCam.py in obs_lsst and make new tests for test_translator.py . 

            Implemented the review comments for  PR#14 to phosim_utils, merged and closed PR.  Released as phosim_utils v.0.2.2 

            ksuberlak Krzysztof Suberlak added a comment - Implemented the review comments for  PR#14 to phosim_utils, merged and closed PR.  Released as phosim_utils  v.0.2.2 

            Opened PR https://github.com/lsst-ts/phosim_syseng4/pull/7 to phosim_syseng4 with updated values for   data/comcam segmentation.txt and focalplanelayout.txt 

            ksuberlak Krzysztof Suberlak added a comment - Opened PR https://github.com/lsst-ts/phosim_syseng4/pull/7  to phosim_syseng4 with updated values for    data/comcam segmentation.txt and focalplanelayout.txt 

            Changes to  data/comcam (as in PR description) are duplicated here for traceability:

             

            Updating `data/comcam` `segmentation.txt` and `focalplanelayout.txt` with geometry and CCD properties appropriate for `lsstComCam` instrument from `obs_lsst` (including recent changes from https://jira.lsstcorp.org/browse/DM-28919).

            All changes are similar to https://github.com/lsst-ts/phosim_syseng4/pull/6 .

            Summary of changes for `focalplanelayout.txt`

            • removal of all rafts besides `R22` (`lsstComCam` consists of one raft, `R22` )
            • Columns 1,2 : x,y -position [microns] updated using `detector.getBBox()`, `bbox.centerY`, `bbox.centerX` (phosim is rotated 90 degrees from lsstComCam)
            • Columns 4,5: number of x,y pixels unchanged (consistent for an ITL chip with `lsstComCam` `xpx = bbox.getHeight()`, `ypx=bbox.getWidth()` )
            • Columns 15,16: x,y shift set to 0,0 since correct positions are provided with Columns 1,2 (most substantially this is noticeable for the corner sensors)

            Summary of changes for `segmentation.txt`:

            • removal of all rafts besides `R22` (`lsstComCam` consists of one raft, `R22` )
            • short lines: no change (sensor names and number of x,y pixels are the same as before)
            • long lines:
            • Columns 1,2,3,4: [xlo, xhi ,ylo, yhi] in px per amplifier - since `lsstComCam` is an ITL, these are unchanged, ( eg. `[0 1999 0 508]` )
            • Columns 5,6 serial read / parallel read : for ITL serial read is always 1, and parallel read is 1 or -1 : these are unchanged
            • Column 7 : new gain values
            • Column 11 : new read noise values
            • Column 15, 16, 17, 18: prescan / overscan values, preserving phosim's rotation of 90 degrees to the left wrt lsstComCam . This means that the following was adopted (and tested):
            phosim name lsstComCam name amplifier property bbox property
            serial overscan parallel prescan
            serial prescan parallel overscan amp.getRawParallelOverscanBBox() bbox.getHeight()
            parallel overscan serial overscan amp.getRawSerialOverscanBBox() bbox.getWidth()
            parallel prescan serial prescan amp.getRawSerialPrescanBBox() bbox.getWidth()

            This translates to

            row meaning \ phosim name parallel prescan serial overscan serial prescan parallel overscan
            phosim values 3 0 10 10
            lsstComCam (ITL) 3 0 48 32
            ksuberlak Krzysztof Suberlak added a comment - Changes to  data/comcam (as in PR description) are duplicated here for traceability:   Updating `data/comcam` `segmentation.txt` and `focalplanelayout.txt` with geometry and CCD properties appropriate for `lsstComCam` instrument from `obs_lsst` (including recent changes from https://jira.lsstcorp.org/browse/DM-28919 ). All changes are similar to https://github.com/lsst-ts/phosim_syseng4/pull/6 . Summary of changes for `focalplanelayout.txt` removal of all rafts besides `R22` (`lsstComCam` consists of one raft, `R22` ) Columns 1,2 : x,y -position [microns] updated using `detector.getBBox()`, `bbox.centerY`, `bbox.centerX` (phosim is rotated 90 degrees from lsstComCam) Columns 4,5: number of x,y pixels unchanged (consistent for an ITL chip with `lsstComCam` `xpx = bbox.getHeight()`, `ypx=bbox.getWidth()` ) Columns 15,16: x,y shift set to 0,0 since correct positions are provided with Columns 1,2 (most substantially this is noticeable for the corner sensors) Summary of changes for `segmentation.txt`: removal of all rafts besides `R22` (`lsstComCam` consists of one raft, `R22` ) short lines: no change (sensor names and number of x,y pixels are the same as before) long lines: Columns 1,2,3,4: [xlo, xhi ,ylo, yhi] in px per amplifier - since `lsstComCam` is an ITL, these are unchanged, ( eg. ` [0 1999 0 508] ` ) Columns 5,6 serial read / parallel read : for ITL serial read is always 1, and parallel read is 1 or -1 : these are unchanged Column 7 : new gain values Column 11 : new read noise values Column 15, 16, 17, 18: prescan / overscan values, preserving phosim's rotation of 90 degrees to the left wrt lsstComCam . This means that the following was adopted (and tested): phosim name lsstComCam name amplifier property bbox property serial overscan parallel prescan – – serial prescan parallel overscan amp.getRawParallelOverscanBBox() bbox.getHeight() parallel overscan serial overscan amp.getRawSerialOverscanBBox() bbox.getWidth() parallel prescan serial prescan amp.getRawSerialPrescanBBox() bbox.getWidth() This translates to row meaning \ phosim name parallel prescan serial overscan serial prescan parallel overscan phosim values 3 0 10 10 lsstComCam (ITL) 3 0 48 32
            ksuberlak Krzysztof Suberlak added a comment - - edited

            Merged the PR to phosim_syseng4

            ksuberlak Krzysztof Suberlak added a comment - - edited Merged the PR to phosim_syseng4
            ttsai Te-Wei Tsai added a comment -

            Reviewed the PRs in this ticket. Good improvement and useful update! Thanks!

            ttsai Te-Wei Tsai added a comment - Reviewed the PRs in this ticket. Good improvement and useful update! Thanks!

            People

              ksuberlak Krzysztof Suberlak
              ksuberlak Krzysztof Suberlak
              Te-Wei Tsai
              Krzysztof Suberlak, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.