Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2929

Some AFW tests are not enabled with no explanation

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Templates:
    • Story Points:
      2
    • Sprint:
      Science Pipelines DM-S15-4, Science Pipelines DM-S15-5
    • Team:
      Alert Production

      Description

      Running coverage.py on the AFW test suite indicated that two test classes in tests/wcs1.py are disabled. WCSTestCaseCFHT was added by Robert Lupton in 2007 but disabled during a merge a long time ago by Jim Bosch in 2010 but with no indication as to why. WCSRotateFlip appeared in 2012 (added by Simon Krughoff) but doesn't appear in the suite list at the end and so does not execute.

      Similarly testSchema.py has two tests that are not run: xtestSchema and testJoin. I assume xtestSchema is deliberately disabled but could there at least be a comment in the test explaining why?

      My feeling is that we should either run the tests or they should be removed. Having them their gives the impression they are doing something useful.

      Less importantly, warpExposure.py has some support code for comparing masked images that was written in 2009 by Russell Owen but which is not used anywhere in the test.

        Attachments

          Activity

            People

            • Assignee:
              krughoff Simon Krughoff
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, John Swinbank, Robert Lupton, Russell Owen, Simon Krughoff, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel