Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29309

Add SAL TEST RPM inspection tests

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_middleware, ts_qa
    • Labels:
      None

      Description

      The command

      rpm -qpl <RPM>

      returns the contents of the RPM.  Use this to add a test case to the salgenerator tests that verifies the TEST RPMs contain the expected files; especially the SAL test programs.

      See https://github.com/lsst-ts/ts_sal/pull/115 for the motivation for this work.

        Attachments

          Issue Links

          clones

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29103 Add SAL RPM inspection tests

          • Done
          has to be done after

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29098 Fix missing SAL test programs in test RPMs

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29103 Add SAL RPM inspection tests

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            rbovill Rob Bovill created issue -
            rbovill Rob Bovill made changes -
            Field Original Value New Value
            Link This issue clones DM-29103 [ DM-29103 ]
            rbovill Rob Bovill made changes -
            Link This issue relates to DM-29103 [ DM-29103 ]
            rbovill Rob Bovill made changes -
            Link This issue has to be done after DM-29098 [ DM-29098 ]
            wvreeven Wouter van Reeven made changes -
            Sprint TSSW Sprint - Mar 1 - Mar 15, TSSW Sprint - Mar 29 - Apr 12 [ 1081, 1086 ] TSSW Sprint - Mar 1 - Mar 15, TSSW Sprint - Mar 29 - Apr 12, TSSW Sprint - Apr 12 - Apr 26 [ 1081, 1086, 1089 ]
            rbovill Rob Bovill made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            rbovill Rob Bovill added a comment -

            Commit adding the "Verify Test RPM" function in the build script generator.

             

            https://github.com/lsst-ts/robotframework_salgenerator/commit/4e216c10a9c456f8e919f5040490c926e94b3f6f

             

            Show
            rbovill Rob Bovill added a comment - Commit adding the "Verify Test RPM" function in the build script generator.   https://github.com/lsst-ts/robotframework_salgenerator/commit/4e216c10a9c456f8e919f5040490c926e94b3f6f  
            Hide
            Permalink
            rbovill Rob Bovill added a comment -

            Commit adding the tests themselves.  Remember, only CSCs that define C++ as a RuntimeLanguage actually generate a TEST RPM.

             

            https://github.com/lsst-ts/robotframework_salgenerator/commit/3d94e7e533d879913939d15f43b6d52d1fee015f

             

            Show
            rbovill Rob Bovill added a comment - Commit adding the tests themselves.  Remember, only CSCs that define C++ as a RuntimeLanguage actually generate a TEST RPM.   https://github.com/lsst-ts/robotframework_salgenerator/commit/3d94e7e533d879913939d15f43b6d52d1fee015f  
            Hide
            Permalink
            rbovill Rob Bovill added a comment -

            Here are the CSCs that do have TEST RPM

            ATMCS_salgenerator.robot
            ATPneumatics_salgenerator.robot
            ATPtg_salgenerator.robot
            Guider_salgenerator.robot
            MTM1M3_salgenerator.robot
            MTM2_salgenerator.robot
            MTMount_salgenerator.robot
            MTPtg_salgenerator.robot
            MTRotator_salgenerator.robot
            WeatherStation_salgenerator.robot

            Show
            rbovill Rob Bovill added a comment - Here are the CSCs that do have TEST RPM ATMCS_salgenerator.robot ATPneumatics_salgenerator.robot ATPtg_salgenerator.robot Guider_salgenerator.robot MTM1M3_salgenerator.robot MTM2_salgenerator.robot MTMount_salgenerator.robot MTPtg_salgenerator.robot MTRotator_salgenerator.robot WeatherStation_salgenerator.robot
            Hide
            Permalink
            rbovill Rob Bovill added a comment -

            Since there were some changes to this process that are not yet released, I created a separate branch in the test/build script repo that contains these tests.  They are run as part of the Bleed build, but not the Daily build.

            https://github.com/lsst-ts/robotframework_salgenerator/tree/sal_develop

            https://tssw-ci.lsst.org/view/SAL_XML/job/RPM_Push_bleed/

             

            Show
            rbovill Rob Bovill added a comment - Since there were some changes to this process that are not yet released, I created a separate branch in the test/build script repo that contains these tests.  They are run as part of the Bleed build, but not the Daily build. https://github.com/lsst-ts/robotframework_salgenerator/tree/sal_develop https://tssw-ci.lsst.org/view/SAL_XML/job/RPM_Push_bleed/  
            rbovill Rob Bovill made changes -
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            dmills Dave Mills added a comment -

            ok

            Show
            dmills Dave Mills added a comment - ok
            dmills Dave Mills made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            rbovill Rob Bovill made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              rbovill Rob Bovill
              Reporter:
              rbovill Rob Bovill
              Reviewers:
              Dave Mills
              Watchers:
              Dave Mills, Rob Bovill
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.