Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2931

We write truncated Wcs data to extended HDU tables in Exposures

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None

      Description

      When we write Wcs to extra HDUs in Exposures they are truncated if other than TAN/TAN-SIP. Please don't write them.

      A better long term solution is needed. In particular, we shouldn't be duplicating this information unnecessarily, and we need to be able to persist e.g. TPV to the tables so as to support CoaddPsf. These issues are not included here.

        Attachments

          Activity

          Hide
          rhl Robert Lupton added a comment -

          Branch tickets/DM-2931

          $ git diff --stat origin/master..
           include/lsst/afw/image/TanWcs.h |  3 +++
           include/lsst/afw/image/Wcs.h    |  3 ++-
           src/image/ExposureInfo.cc       |  5 ++++-
           src/image/TanWcs.cc             |  8 ++++++++
           src/image/Wcs.cc                | 11 ++++++++++-
           src/image/makeWcs.cc            |  2 +-
           6 files changed, 28 insertions(+), 4 deletions(-)
          

          Show
          rhl Robert Lupton added a comment - Branch tickets/ DM-2931 $ git diff --stat origin/master.. include/lsst/afw/image/TanWcs.h | 3 +++ include/lsst/afw/image/Wcs.h | 3 ++- src/image/ExposureInfo.cc | 5 ++++- src/image/TanWcs.cc | 8 ++++++++ src/image/Wcs.cc | 11 ++++++++++- src/image/makeWcs.cc | 2 +- 6 files changed, 28 insertions(+), 4 deletions(-)
          Hide
          swinbank John Swinbank added a comment -

          Would you mind filing an issue to capture the work described in the description but which is out of scope for this issue? Thanks!

          Show
          swinbank John Swinbank added a comment - Would you mind filing an issue to capture the work described in the description but which is out of scope for this issue? Thanks!
          Hide
          jbosch Jim Bosch added a comment -

          A few comments on the attached GitHub PR. Nothing major, but I do second Kian-Tat Lim's request for some test code. In particular, including a test that round-trips the (TPV?) WCS that prompted this seems like a good idea.

          Show
          jbosch Jim Bosch added a comment - A few comments on the attached GitHub PR. Nothing major, but I do second Kian-Tat Lim 's request for some test code. In particular, including a test that round-trips the (TPV?) WCS that prompted this seems like a good idea.
          Hide
          rhl Robert Lupton added a comment -

          Added test as requested and merged to master

          Show
          rhl Robert Lupton added a comment - Added test as requested and merged to master

            People

            • Assignee:
              rhl Robert Lupton
              Reporter:
              rhl Robert Lupton
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, John Swinbank, Robert Lupton
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel