# We write truncated Wcs data to extended HDU tables in Exposures

XMLWordPrintable

## Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
1
• Sprint:
Science Pipelines DM-S15-4
• Team:
Data Release Production

## Description

When we write Wcs to extra HDUs in Exposures they are truncated if other than TAN/TAN-SIP. Please don't write them.

A better long term solution is needed. In particular, we shouldn't be duplicating this information unnecessarily, and we need to be able to persist e.g. TPV to the tables so as to support CoaddPsf. These issues are not included here.

## Activity

Hide
Robert Lupton added a comment -

Branch tickets/DM-2931

 $git diff --stat origin/master..  include/lsst/afw/image/TanWcs.h | 3 +++  include/lsst/afw/image/Wcs.h | 3 ++-  src/image/ExposureInfo.cc | 5 ++++-  src/image/TanWcs.cc | 8 ++++++++  src/image/Wcs.cc | 11 ++++++++++-  src/image/makeWcs.cc | 2 +-  6 files changed, 28 insertions(+), 4 deletions(-)  Show Robert Lupton added a comment - Branch tickets/ DM-2931$ git diff --stat origin/master.. include/lsst/afw/image/TanWcs.h | 3 +++ include/lsst/afw/image/Wcs.h | 3 ++- src/image/ExposureInfo.cc | 5 ++++- src/image/TanWcs.cc | 8 ++++++++ src/image/Wcs.cc | 11 ++++++++++- src/image/makeWcs.cc | 2 +- 6 files changed, 28 insertions(+), 4 deletions(-)
Hide
John Swinbank added a comment -

Would you mind filing an issue to capture the work described in the description but which is out of scope for this issue? Thanks!

Show
John Swinbank added a comment - Would you mind filing an issue to capture the work described in the description but which is out of scope for this issue? Thanks!
Hide
Jim Bosch added a comment -

A few comments on the attached GitHub PR. Nothing major, but I do second Kian-Tat Lim's request for some test code. In particular, including a test that round-trips the (TPV?) WCS that prompted this seems like a good idea.

Show
Jim Bosch added a comment - A few comments on the attached GitHub PR. Nothing major, but I do second Kian-Tat Lim 's request for some test code. In particular, including a test that round-trips the (TPV?) WCS that prompted this seems like a good idea.
Hide
Robert Lupton added a comment -

Added test as requested and merged to master

Show
Robert Lupton added a comment - Added test as requested and merged to master

## People

• Assignee:
Robert Lupton
Reporter:
Robert Lupton
Reviewers:
Jim Bosch
Watchers:
Jim Bosch, John Swinbank, Robert Lupton