Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29325

Update mask name in for vignetted region to match established convention

    XMLWordPrintable

    Details

    • Type: Story
    • Status: In Progress
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: cp_pipe

      Description

      As was noted on DM-29280, and quoting from this comment,
      Ok, as for the vignetting mask setting, I think we're currently living in a strange and inconsistent state.  As noted above, obs_subaru assigns a NO_DATA plane to the vignetted region of the calibration FLAT (and thus gets propagated via mask OR-ing when the FLAT is applied).  On the other hand, the only other place I can find in the codebase where a similar masking is attached to the FLAT is in the CpFlatMeasureTask in cp_pipe, but this function uses the BAD mask plane for the vignette masking (also in the default function parameter setting here and, as a side note, no polygon is passed in, so unless the FLAT has a getValidPolygon() set, this will raise with a RuntimeError). I would think these mask names & definitions should be kept consistent.
      And, indeed, they should. obs_subaru has the set the long-standing convention of marking the vignetted region with the NO_DATA mask plane, so the same should be done in cp_pipe.

        Attachments

          Issue Links

            Activity

            Hide
            lauren Lauren MacArthur added a comment - - edited

            I have pushed a branch to make this update, but I would like to do some "playing" with the new mask name setting using DC2 data, but am currently blocked on an issue in processing those data (see details in this slack posting).

            Show
            lauren Lauren MacArthur added a comment - - edited I have pushed a branch to make this update, but I would like to do some "playing" with the new mask name setting using DC2 data, but am currently blocked on an issue in processing those data (see details in this slack posting ).

              People

              Assignee:
              lauren Lauren MacArthur
              Reporter:
              lauren Lauren MacArthur
              Watchers:
              Christopher Waters, Lauren MacArthur
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: