Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29326

Fix logic of the doVignette option in isrTask

    XMLWordPrintable

Details

    • 4
    • Data Release Production
    • No

    Description

      As was noted in DM-29280 (and directly quoting from this comment):

      Now, in isrTask, there is a doVignette config said to "Apply vignetting parameters", but I am very puzzled by this option. It fires only after all the other ISR operations have fired (so none of them would know about any effect this operation has). If True, it calls the VignetteTask in ip_isr, but that task returns None unless the config parameter doWriteVignettePolygon is True, in which case it returns a polygon. In other words, if doWriteVignettePolygon is False, the call to this function is a no-op, so why make it at all? Also, the function gets an exposure passed in as a required parameter, but as far as I can tell, it is not used (nor updated) in the function. If doWriteVignettePolygon is indeed True, then the validPolygon is attached to the exposure (but it doesn't seem that any mask bits are set...but that might be as intended).

      This all seems to be a bit of a mess as one can have a validPolygon representing the vignetted region attached to an exposure, but this does not imply a mask bit will be set...

      This purpose of this ticket is to clean up the logic surrounding the validPolygon setting and masking, and usage therein, of the vignetted region of a detector.

      Attachments

        Issue Links

          Activity

            No builds found.
            lauren Lauren MacArthur created issue -
            lauren Lauren MacArthur made changes -
            Field Original Value New Value
            Link This issue relates to DM-29280 [ DM-29280 ]
            czw Christopher Waters made changes -
            Assignee Christopher Waters [ cwaters ]
            lauren Lauren MacArthur made changes -
            Assignee Christopher Waters [ cwaters ] Lauren MacArthur [ lauren ]
            lauren Lauren MacArthur made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]

            I've been playing around with this, so will take it over (for now...if and up until I get stuck!)

            lauren Lauren MacArthur added a comment - I've been playing around with this, so will take it over (for now...if and up until I get stuck!)
            yusra Yusra AlSayyad made changes -
            Epic Link DM-29158 [ 458521 ] DM-30477 [ 509210 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-30477 [ 509210 ] DM-30539 [ 511197 ]
            czw Christopher Waters made changes -
            Reviewers Andrés Alejandro Plazas Malagón [ plazas ]
            Status In Progress [ 3 ] In Review [ 10004 ]

            It makes sense to me. I just left some minor comments.

            plazas Andrés Alejandro Plazas Malagón added a comment - It makes sense to me. I just left some minor comments.
            plazas Andrés Alejandro Plazas Malagón made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            czw Christopher Waters made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            czw Christopher Waters made changes -
            Assignee Lauren MacArthur [ lauren ] Christopher Waters [ cwaters ]
            czw Christopher Waters made changes -
            Story Points 4
            yusra Yusra AlSayyad made changes -
            Epic Link DM-30539 [ 511197 ] DM-30546 [ 511212 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-30546 [ 511212 ] DM-30539 [ 511197 ]

            People

              czw Christopher Waters
              lauren Lauren MacArthur
              Andrés Alejandro Plazas Malagón
              Andrés Alejandro Plazas Malagón, Christopher Waters, Jim Bosch, Lauren MacArthur
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.