Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
There are several Python packages in the stack, where the package's python directory is appended to PYTHONPATH environment variable instead of prepending. This should be fixed across all packages in the stack.
This ticket is filed motivated by this conversation in a code review: https://github.com/lsst-dm/meas_extensions_gaap/pull/3#discussion_r578639435
Attachments
Issue Links
- relates to
-
- Done
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Assignee | Arun Kannawadi [ kannawad ] |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Story Points | 1 |
| Description | There are several Python packages in the stack, where the package's python directory is appended to PYTHONPATH environment variable instead of prepending. This should be fixed across all packages in the stack. |
There are several Python packages in the stack, where the package's python directory is appended to PYTHONPATH environment variable instead of prepending. This should be fixed across all packages in the stack.
This ticket is filed motivated by this conversation in a code review: https://github.com/lsst-dm/meas_extensions_gaap/pull/3#discussion_r578639435 |
| Labels | PairCoding |
Note that many of these packages are obsolete and unused, but fixing them doesn't hurt.
I think jointcal, fgcm, meas_extensions_convolved, and meas_algorithms are the ones that need fixing.
Agreed. I was wondering about that when I checked out some of these packages since I had never heard of them. Since this is nevertheless org-wide, would you mind reviewing the PRs Kian-Tat Lim?
The only commit that is different is this in sims_selfcal package (if relevant), where including LD_LIBRARY_PATH and DYLD_LIBRARY_PATH are removed since they are Python-only packages.
Tim Jenness, I don't see the use of envAppend in fgcmcal
Thanks, fixed it. I'll let Eli merge the PR to fgcm when convenient. For other packages, would either Tim or K-T be the reviewers?
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Reviewers | Kian-Tat Lim [ ktl ] |
| Status | In Review [ 10004 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
A problem with obs_wiyn, and I think lsstserver should remain as is, but otherwise OK.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Fixed the problem with obs_wiyn and merged all PRs except the lsstserver package one. Marking it as Done now.
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
This is a continuation of organization-wide move to change `envAppend`s to `envPrepend`s, similar to the commits named "Replace envAppend with envPrepend in ups table files." by Robyn AllsMann in Nov 2014.